fix(types): move @types/debug from devDependencies to dependencies#290
Open
YevheniiKotyrlo wants to merge 1 commit intonativewind:mainfrom
Open
fix(types): move @types/debug from devDependencies to dependencies#290YevheniiKotyrlo wants to merge 1 commit intonativewind:mainfrom
YevheniiKotyrlo wants to merge 1 commit intonativewind:mainfrom
Conversation
3153651 to
6683bdb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compiler.types.tsexports theDebuggertype from"debug"in the publicCompilerOptions.loggertype:This type is re-exported from the
./compilerentry point and published in the.d.tsfiles underdist/typescript/. However,@types/debugis listed indevDependencies, so it's not installed for consumers. Thedebugpackage itself ships no type declarations.Consumers with
skipLibCheck: falseget:This affects all NativeWind users because
nativewind/metroimportsreact-native-css/metro, which transitively imports the compiler module:Fix
Move
@types/debugfromdevDependenciestodependencies.debugis already a runtime dependency — its type declarations should follow.Test plan
yarn typecheck— passyarn lint— passyarn build— pass (module + commonjs + typescript)yarn test— 969 passed, 3 pre-existing failures in babel plugin tests (unrelated)@types/debug, resolves with it installed