refactor: solid account page (@fehmer) by fehmer · Pull Request #7537 · monkeytypegame/monkeytype

fehmer · 2026-02-26T10:56:10Z

No description provided.

…hart

socket-security · 2026-02-26T10:59:26Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	etag@1.8.1
	dotenv@16.4.5

View full report

socket-security · 2026-02-27T14:33:40Z

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action	Severity	Alert (click "▶" to expand/collapse)
Warn		Critical CVE: npm `form-data` uses unsafe random function in form-data for choosing boundary CVE: GHSA-fjxv-7rqg-78g4 form-data uses unsafe random function in form-data for choosing boundary (CRITICAL) Affected versions: < 2.5.4; >= 3.0.0 < 3.0.4; >= 4.0.0 < 4.0.4 Patched version: 4.0.4 From: pnpm-lock.yaml → `npm/form-data@4.0.0` ℹ Read more on: This package \| This alert \| What is a critical CVE? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `support@socket.dev`. Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/form-data@4.0.0`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Warn		Obfuscated code: npm `entities` is 91.0% likely obfuscated Confidence: 0.91 Location: Package overview From: pnpm-lock.yaml → `npm/entities@4.5.0` ℹ Read more on: This package \| This alert \| What is obfuscated code? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `support@socket.dev`. Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/entities@4.5.0`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Warn		Obfuscated code: npm `ioredis` is 96.0% likely obfuscated Confidence: 0.96 Location: Package overview From: pnpm-lock.yaml → `npm/ioredis@5.4.1` ℹ Read more on: This package \| This alert \| What is obfuscated code? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `support@socket.dev`. Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/ioredis@5.4.1`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

github-actions · 2026-03-08T14:50:30Z

frontend/src/ts/collections/results.ts

+  mapping?: Record<T, U>,
+): U[] {
+  return Object.entries(val)
+    .filter(([_, v]) => v as boolean) //TODO remove as?


A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.
TODO remove as?

github-actions · 2026-03-08T14:50:31Z

frontend/src/ts/components/pages/account/AccountPage.tsx

+import { TestStats } from "./TestStats";
+
+export function AccountPage(): JSXElement {
+  //TODO change page


A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.
TODO change page

github-actions · 2026-03-08T14:50:31Z

frontend/src/ts/components/pages/account/TestStats.tsx

+    () => last10StatsQuery()[0] as ResultStats,
+  );
+
+  //TODO use asynccontent or loader


A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.
TODO use asynccontent or loader

github-actions · 2026-03-09T08:47:10Z

frontend/src/ts/components/pages/account/AccountPage.tsx

+
+  const data = useResultsLiveQuery({ queryState, sorting, limit });
+
+  //TODO ads


A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.
TODO ads

github-actions · 2026-03-09T08:47:11Z

frontend/src/ts/controllers/page-controller.ts

+            "Looks like your account data didn't download correctly. Please refresh the page.<br>If this error persists, please contact support.",
+          );
+        }
+        //TODO prefetch


A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.
TODO prefetch

github-actions · 2026-03-09T08:47:11Z

frontend/src/ts/elements/result-batches.ts

 import { getTheme } from "../signals/theme";
 import { qs } from "../utils/dom";

+//TODO


A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.
TODO

github-actions · 2026-03-09T08:47:12Z

frontend/src/ts/modals/edit-result-tags.ts


  if (state.source === "accountPage") {
-    AccountPage.updateTagsForResult(state.resultId, state.tags);
+    //TODO AccountPage.updateTagsForResult(state.resultId, state.tags);


A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.
TODO AccountPage.updateTagsForResult(state.resultId, state.tags);

fehmer and others added 30 commits February 17, 2026 16:00

wip

c480e81

wip

1777458

wip

e059de8

wip

5b9a9b0

working filter and sorting

7f7f5b4

working filter and sorting

0cae531

be migrate, move liveQuery and filters to collections/results

e6eb759

wip

3cc6521

wip

a4ae35f

complete filters?

dd708a5

forgot the quoteLength

9385711

simplify

7f55e67

styles

003f571

buttons

cdf66bf

dropdowns. filter, funbox filter is missing

58220bb

missing funbox filter

42ae60d

use store with localStorage

7a132ad

all option

ac17b51

wip

7f67049

wip

df6c355

wip

eaf3bdc

memo

55cd549

wip

6ce8b79

wip

ef88310

fix tags

611c06d

better types, add charts filter summary

a82292c

wip

414e32a

wip

b7fb022

settings

8f4fdb7

simplify onChange

8ce62f7

fehmer added 7 commits February 20, 2026 19:27

some charts

87a3615

add label, refactor, add trend

822462f

fixes

18a528e

buttons

24b5542

fix grid colors not updating, extract history chart, fix about page c…

3a87665

…hart

add histogramChart

9fe9fbe

add daily activity chart

9cb313e

monkeytypegeorge added backend Server stuff frontend User interface or web stuff packages Changes in local packages labels Feb 26, 2026

Merge branch 'master' into feature/solid-results

7ffc204

fehmer added 5 commits February 27, 2026 11:22

clear filters button

b8ba5e7

refactor filter callback, current settings button

1af312a

filter presets

87e30ff

fill filter presets collection from snapshot directly

26db09c

Merge branch 'master' into feature/solid-results

84f30ed

fehmer added 2 commits February 27, 2026 15:43

fix AnimatedModal test

62a6947

Merge branch 'master' into feature/solid-results

c8ddd61

github-actions bot reviewed Mar 8, 2026

View reviewed changes

fehmer added 2 commits March 8, 2026 15:52

clenaup

a8d2bf3

move page

25a4b1c

github-actions bot reviewed Mar 9, 2026

View reviewed changes

Merge branch 'master' into feature/solid-results

85a4978

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor: solid account page (@fehmer)#7537

refactor: solid account page (@fehmer)#7537
fehmer wants to merge 59 commits intomasterfrom
feature/solid-results

fehmer commented Feb 26, 2026

Uh oh!

socket-security bot commented Feb 26, 2026 •

edited

Loading

Uh oh!

socket-security bot commented Feb 27, 2026 •

edited

Loading

Uh oh!

github-actions bot Mar 8, 2026

Uh oh!

github-actions bot Mar 8, 2026

Uh oh!

github-actions bot Mar 8, 2026

Uh oh!

github-actions bot Mar 9, 2026

Uh oh!

github-actions bot Mar 9, 2026

Uh oh!

github-actions bot Mar 9, 2026

Uh oh!

github-actions bot Mar 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		const data = useResultsLiveQuery({ queryState, sorting, limit });

		//TODO ads

Uh oh!

Conversation

fehmer commented Feb 26, 2026

Uh oh!

socket-security bot commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security bot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

socket-security bot commented Feb 26, 2026 •

edited

Loading

socket-security bot commented Feb 27, 2026 •

edited

Loading