Merged
Conversation
DaleSeo
previously approved these changes
Mar 4, 2026
conformance/src/bin/client.rs
Outdated
| // ─── Context parsed from MCP_CONFORMANCE_CONTEXT ──────────────────────────── | ||
|
|
||
| #[derive(Debug, Default, serde::Deserialize)] | ||
| #[allow(dead_code)] |
Member
There was a problem hiding this comment.
Is it for backward compatibility? ConformanceContext::name (and possibly other fields) now appears to go unused after the OAuthClientConfig import was removed.
Contributor
Author
There was a problem hiding this comment.
made a small change here to address and it needs new review
alexhancock
force-pushed
the
alexhancock/conformance-syntax
branch
from
9793a47 to
c37b9f5
Compare
felixweinberger
approved these changes
Mar 5, 2026
felixweinberger
left a comment
felixweinberger
left a comment
There was a problem hiding this comment.
Used this to verify conformance passing modelcontextprotocol/modelcontextprotocol#2346
DaleSeo
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required to get the conformance server & client running again after the
non_exhaustiverefactor