Add automatic _meta parameter extraction support#172
Open
erickreutz wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Add automatic _meta parameter extraction support#172erickreutz wants to merge 1 commit intomodelcontextprotocol:mainfrom
erickreutz wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
fdb400a to
ad9677a
Compare
scutuatua-crypto
approved these changes
Jan 10, 2026
0a22bf1 to
d20733b
Compare
Author
|
@scutuatua-crypto lgtm? |
koic
reviewed
Mar 4, 2026
lib/mcp/server.rb
Outdated
| context | ||
| end | ||
|
|
||
| call_prompt_template_with_args(prompt, prompt_args, context_with_meta) |
Member
There was a problem hiding this comment.
The code duplication caught my attention. Could it be updated as a change like the following overall?
index e9a4e50..862c3cd 100644
--- a/lib/mcp/server.rb
+++ b/lib/mcp/server.rb
@@ -419,7 +419,7 @@ module MCP
end
end
- call_tool_with_args(tool, arguments)
+ call_tool_with_args(tool, arguments, server_context_with_meta(request))
rescue RequestHandlerError
raise
rescue => e
@@ -445,7 +445,7 @@ module MCP
prompt_args = request[:arguments]
prompt.validate_arguments!(prompt_args)
- call_prompt_template_with_args(prompt, prompt_args)
+ call_prompt_template_with_args(prompt, prompt_args, server_context_with_meta(request))
end
def list_resources(request)
@@ -488,7 +488,7 @@ module MCP
parameters.any? { |type, name| type == :keyrest || name == :server_context }
end
- def call_tool_with_args(tool, arguments)
+ def call_tool_with_args(tool, arguments, server_context)
args = arguments&.transform_keys(&:to_sym) || {}
if accepts_server_context?(tool.method(:call))
@@ -498,12 +498,25 @@ module MCP
end
end
- def call_prompt_template_with_args(prompt, args)
+ def call_prompt_template_with_args(prompt, args, server_context)
if accepts_server_context?(prompt.method(:template))
prompt.template(args, server_context: server_context).to_h
else
prompt.template(args).to_h
end
end
+
+ def server_context_with_meta(request)
+ meta = request[:_meta]
+ if @server_context && meta
+ context = @server_context.dup
+ context[:_meta] = meta
+ context
+ elsif meta
+ { _meta: meta }
+ elsif @server_context
+ @server_context
+ end
+ end
end
end
koic
reviewed
Mar 4, 2026
test/mcp/server_context_test.rb
Outdated
| response[:result][:messages][0][:content][:text] | ||
| end | ||
|
|
||
| # _meta extraction tests |
Member
There was a problem hiding this comment.
This comment appears unnecessary since it is already explained in the test code.
koic
reviewed
Mar 4, 2026
test/mcp/server_context_test.rb
Outdated
|
|
||
| class << self | ||
| def call(message:, server_context: nil) | ||
| meta_info = server_context&.dig(:_meta, :provider, :metadata) || "no metadata" |
Member
There was a problem hiding this comment.
In this test, it appears that a server_context with _meta set is always passed.
Suggested change
| meta_info = server_context&.dig(:_meta, :provider, :metadata) || "no metadata" | |
| def call(message:, server_context:) | |
| meta_info = server_context.dig(:_meta, :provider, :metadata) |
koic
reviewed
Mar 4, 2026
test/mcp/server_context_test.rb
Outdated
| class << self | ||
| def call(message:, server_context: nil) | ||
| user = server_context&.dig(:user) || "unknown" | ||
| session_id = server_context&.dig(:_meta, :session_id) || "unknown" |
Member
There was a problem hiding this comment.
Suggested change
| session_id = server_context&.dig(:_meta, :session_id) || "unknown" | |
| def call(message:, server_context:) | |
| user = server_context[:user] | |
| session_id = server_context.dig(:_meta, :session_id) |
koic
reviewed
Mar 4, 2026
test/mcp/server_context_test.rb
Outdated
| class << self | ||
| def call(server_context: nil) | ||
| priority = server_context&.dig(:priority) || "none" | ||
| meta_priority = server_context&.dig(:_meta, :priority) || "none" |
Member
There was a problem hiding this comment.
Suggested change
| meta_priority = server_context&.dig(:_meta, :priority) || "none" | |
| def call(server_context:) | |
| priority = server_context[:priority] | |
| meta_priority = server_context.dig(:_meta, :priority) |
koic
reviewed
Mar 4, 2026
test/mcp/server_context_test.rb
Outdated
|
|
||
| class << self | ||
| def template(args, server_context: nil) | ||
| meta_info = server_context&.dig(:_meta, :request_id) || "no request id" |
Member
There was a problem hiding this comment.
Suggested change
| meta_info = server_context&.dig(:_meta, :request_id) || "no request id" | |
| def template(args, server_context:) | |
| meta_info = server_context.dig(:_meta, :request_id) |
koic
reviewed
Mar 4, 2026
test/mcp/server_context_test.rb
Outdated
Comment on lines
+600
to
+602
| def template(args, server_context: nil) | ||
| user = server_context&.dig(:user) || "unknown" | ||
| trace_id = server_context&.dig(:_meta, :trace_id) || "unknown" |
Member
There was a problem hiding this comment.
Suggested change
| def template(args, server_context: nil) | |
| user = server_context&.dig(:user) || "unknown" | |
| trace_id = server_context&.dig(:_meta, :trace_id) || "unknown" | |
| def template(args, server_context:) | |
| user = server_context[:user] | |
| trace_id = server_context.dig(:_meta, :trace_id) |
koic
reviewed
Mar 4, 2026
README.md
Outdated
Comment on lines
+312
to
+318
| def self.call(message:, server_context: nil) | ||
| # Access provider-specific metadata | ||
| session_id = server_context&.dig(:_meta, :session_id) | ||
| request_id = server_context&.dig(:_meta, :request_id) | ||
|
|
||
| # Access server's original context | ||
| user_id = server_context&.dig(:user_id) |
Member
There was a problem hiding this comment.
It seems that the example would be simpler if written as follows.
Suggested change
| def self.call(message:, server_context: nil) | |
| # Access provider-specific metadata | |
| session_id = server_context&.dig(:_meta, :session_id) | |
| request_id = server_context&.dig(:_meta, :request_id) | |
| # Access server's original context | |
| user_id = server_context&.dig(:user_id) | |
| def self.call(message:, server_context:) | |
| # Access provider-specific metadata | |
| session_id = server_context.dig(:_meta, :session_id) | |
| request_id = server_context.dig(:_meta, :request_id) | |
| # Access server's original context | |
| user_id = server_context.dig(:user_id) |
d20733b to
879856e
Compare
The MCP protocol specification includes a _meta parameter that allows clients to pass request-specific metadata. This commit adds automatic extraction of this parameter and makes it available to tools and prompts as a nested field within server_context. Key changes: - Extract _meta from request params in call_tool and get_prompt methods - Pass _meta as a nested field in server_context (server_context[:_meta]) - Only create context when there's either server_context or _meta present - Add comprehensive tests for _meta extraction and nesting - Update documentation with _meta usage examples and link to spec This maintains compatibility with TypeScript and Python SDKs which also nest _meta within the context rather than merging it at the top level.
879856e to
4ca32c5
Compare
Author
|
@koic feedback addressed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds native support for the MCP protocol's
_metaparameter, eliminating the need for manual extraction in controllers.Background
The MCP specification defines a
_metafield that allows clients to pass request-specific metadata. Previously, Ruby SDK users had to manually extract this field from request parameters.Changes
_metafrom request parameters incall_toolandget_promptmethods_metais passed as a nested field withinserver_context(accessible viaserver_context[:_meta])_metawithin the contextserver_contextor_metapresentTesting
_metaextraction and nesting behaviorDocumentation
_metausage examplesUsage Example
Breaking Changes
None - this is backwards compatible. Tools that don't use
server_contextor don't access_metawill continue to work unchanged.Notes
While implementing this feature, we discovered that the README incorrectly states that server_context is passed to exception and instrumentation callbacks, though the actual implementation only passes contextual error information to these callbacks.