fix: accept wildcard media types in Accept header per RFC 7231#2152
Open
shivama205 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix: accept wildcard media types in Accept header per RFC 7231#2152shivama205 wants to merge 1 commit intomodelcontextprotocol:mainfrom
shivama205 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Author
Author
|
@felixweinberger @maxisbey could you please review this when you get a chance? Thanks! |
The server rejected requests with wildcard Accept headers like `*/*`, `application/*`, or `text/*`, returning 406 Not Acceptable. This violated RFC 7231, section 5.3.2, which defines wildcard media ranges as valid. Update `_check_accept_headers` to recognize `*/*` as matching all types, `application/*` as matching `application/json`, and `text/*` as matching `text/event-stream`. Also strip quality parameters before matching. Github-Issue:modelcontextprotocol#1641 Reported-by:rh-fr
shivama205
force-pushed
the
fix/accept-header-wildcards
branch
from
b5d0136 to
6c49c5f
Compare
Author
|
Bumping this — just rebased onto latest If anyone's on the MCP Discord, would really appreciate a ping to get eyes on this. Happy to make any changes to get it merged. 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_check_accept_headersto accept wildcard media types (*/*,application/*,text/*) in theAcceptheader, per RFC 7231, section 5.3.2;q=0.8) before matching media typesProblem
The server rejected requests with wildcard
Acceptheaders like*/*orapplication/*, returning406 Not Acceptable. This violated RFC 7231 and broke interoperability with HTTP clients that sendAccept: */*by default (e.g.httpx,requests).Closes #1641
Test plan
*/*accepted for both SSE and JSON-only modesapplication/*+text/*accepted for SSE modeapplication/*alone correctly rejected for SSE mode (doesn't covertext/event-stream)*/*;q=0.8) handled correctlytext/html) still rejected