Revert "Polish question carousel (#298377)"

[daviddossett]

Reverts #298377. Will re-raise with accessibility tweaks.

[Copilot]

Pull request overview

Reverts PR #298377’s “polished” question carousel/tabbed flow and related chat UI/action/theme changes, with intent to reintroduce later with accessibility tweaks.

Changes:

• Removes the carousel tab-bar/review flow and restores a simpler per-question UI with footer navigation/submit behavior.
• Reverts AskQuestionsTool progress text and removes header display formatting support + its unit test.
• Reverts chat execute/queue action context gating and rolls back theme/CSS adjustments made for the carousel.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/vs/workbench/contrib/chat/test/common/tools/builtinTools/askQuestionsTool.test.ts	Removes the formatHeaderForDisplay unit test import/coverage as part of reverting header formatting.
src/vs/workbench/contrib/chat/test/browser/widget/chatContentParts/chatQuestionCarouselPart.test.ts	Updates carousel rendering/navigation/accessibility assertions to match reverted UI structure.
src/vs/workbench/contrib/chat/common/tools/builtinTools/askQuestionsTool.ts	Removes formatHeaderForDisplay, restores older progress message, and reverts header truncation behavior.
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/media/chatQuestionCarousel.css	Reverts carousel styling to a different layout/visual design (including updated footer/nav styling).
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatQuestionCarouselPart.ts	Replaces tab-bar/review behavior with footer step indicator + prev/next/submit controls and updates summary formatting.
src/vs/workbench/contrib/chat/browser/actions/chatQueueActions.ts	Reverts when-conditions so queue/steer actions no longer show during pending carousel/tool confirmation states.
src/vs/workbench/contrib/chat/browser/actions/chatExecuteActions.ts	Reverts execute toolbar context-key logic, including Cancel visibility behavior.
extensions/theme-2026/themes/styles.css	Removes carousel/chat border-radius styling introduced in #298377.
extensions/theme-2026/themes/2026-dark.json	Reverts the list.activeSelectionBackground tweak made for the carousel UI.

Comments suppressed due to low confidence (2)

src/vs/workbench/contrib/chat/browser/widget/chatContentParts/media/chatQuestionCarousel.css:23

• This file introduces hardcoded pixel corner radii (e.g. border-radius: 4px). In VS Code CSS we should use the theme size tokens (var(--vscode-cornerRadius-*)) so radii are consistent across themes and can be adjusted centrally (see src/vs/platform/theme/common/sizes/baseSizes.ts). Please replace these hardcoded values with the appropriate --vscode-cornerRadius-* variable (likely small here).

.interactive-session .interactive-input-part > .chat-question-carousel-widget-container .chat-question-carousel-container {
	margin: 0;
	border: 1px solid var(--vscode-input-border, transparent);
	background-color: var(--vscode-editor-background);
	border-radius: 4px;
}

/* general questions styling */
.interactive-session .chat-question-carousel-container {
	margin: 8px 0;
	border: 1px solid var(--vscode-chat-requestBorder);
	border-radius: 4px;

src/vs/workbench/contrib/chat/browser/widget/chatContentParts/media/chatQuestionCarousel.css:185

• More hardcoded pixel radii are introduced for interactive list items (border-radius: 3px). Please use var(--vscode-cornerRadius-*) instead so the list items match other components and respect theme sizing tokens.

			gap: 8px;
			padding: 3px 8px;
			cursor: pointer;
			border-radius: 3px;
			user-select: none;

[daviddossett]

Reverts PR https://github.com/microsoft/vscode/pull/298377’s “polished” question

dang, passive aggressive copilot