Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new telemetry datapoint to the existing terminal/createInstance event to understand whether the xterm.js image addon is actually loaded for a terminal instance.
Changes:
- Expose
XtermTerminal.isImageAddonLoadedbased on whether the image addon has been instantiated. - Log a new boolean field
imageAddonLoadedinterminal/createInstancetelemetry with proper classification metadata.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/vs/workbench/contrib/terminal/browser/xterm/xtermTerminal.ts |
Adds an isImageAddonLoaded getter to expose whether the xterm image addon is present. |
src/vs/workbench/contrib/terminal/browser/terminalTelemetry.ts |
Extends terminal/createInstance telemetry to include imageAddonLoaded with classification metadata and logging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of: #299058
I wanted to get a better sense of image usage
Upcoming xtermjs/xterm.js#5733 to get a sense of individual image count too.