allow omitting --quiet flag in heft-storybook-plugin without requiring --verbose#5681
Open
UberMouse wants to merge 1 commit intomicrosoft:mainfrom
Open
allow omitting --quiet flag in heft-storybook-plugin without requiring --verbose#5681UberMouse wants to merge 1 commit intomicrosoft:mainfrom
UberMouse wants to merge 1 commit intomicrosoft:mainfrom
Conversation
UberMouse
requested review from
apostolisms,
iclanton and
octogonz
as code owners
UberMouse
requested review from
bmiddha,
dmichon-msft and
jxanthony
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an option to control whether the plugin supplies
--quietto Storybook when starting the dev serverDetails
Added an option that defaults to true to maintain backwards compatible behaviour
When set to false it causes
--quietnot to be supplied to StorybookIf true supplying
--verbosestill removes--quietjust as beforeHow it was tested
Ran the heft-storybook-v9-tutorial with the flag set to
false: storybook output is not silenced
true: storybook output is silenced
omitted: storybook output is silenced
omitted, --verbose: storybook output is not silenced
Impacted documentation