Skip to content

feat(cdp): add 'event' and 'close' events to CDPSession#39552

Open
yury-s wants to merge 1 commit intomicrosoft:mainfrom
yury-s:cdp-session-events
Open

feat(cdp): add 'event' and 'close' events to CDPSession#39552
yury-s wants to merge 1 commit intomicrosoft:mainfrom
yury-s:cdp-session-events

Conversation

@yury-s
Copy link
Member

@yury-s yury-s commented Mar 7, 2026

  • 'event' fires for every CDP event with { name, params? }, allowing subscriptions to all CDP events without knowing names ahead of time
  • 'close' fires when the session is detached or the target closes

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

- 'event' fires for every CDP event with { name, params? }, allowing
  subscriptions to all CDP events without knowing names ahead of time
- 'close' fires when the session is detached or the target closes
@yury-s yury-s force-pushed the cdp-session-events branch from ecf3733 to efb1e1d Compare March 7, 2026 15:23
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2026

Test results for "tests 1"

1 failed
❌ [playwright-test] › reporter-line.spec.ts:193 › merged › should show error context with relative path @macos-latest-node20

4 flaky ⚠️ [chromium-library] › library/popup.spec.ts:260 › should not throw when click closes popup `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1080 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1216 › should display language-specific locators `@webkit-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:433 › should work behind reverse proxy `@macos-latest-node20`

38379 passed, 797 skipped


Merge workflow run.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2026

Test results for "MCP"

6 failed
❌ [chrome] › mcp/cli-session.spec.ts:126 › session reopen with different config @mcp-macos-15
❌ [chromium] › mcp/cli-session.spec.ts:126 › session reopen with different config @mcp-macos-15
❌ [firefox] › mcp/cli-session.spec.ts:126 › session reopen with different config @mcp-macos-15
❌ [firefox] › mcp/http.spec.ts:207 › http transport browser lifecycle (persistent) @mcp-macos-15
❌ [webkit] › mcp/cli-session.spec.ts:126 › session reopen with different config @mcp-macos-15
❌ [webkit] › mcp/http.spec.ts:207 › http transport browser lifecycle (persistent) @mcp-macos-15

5085 passed, 161 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants