Add getSuspendPostUri and getResumePostUri getters to HttpManagementPayload#264
Open
Add getSuspendPostUri and getResumePostUri getters to HttpManagementPayload#264
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds missing suspend/resume management endpoint getters to HttpManagementPayload (used by Azure Functions HTTP management payloads) and introduces a small unit test suite to validate URL generation, along with Gradle test configuration updates for the endtoendtests module.
Changes:
- Add
getSuspendPostUri()andgetResumePostUri()getters toHttpManagementPayload. - Add
HttpManagementPayloadTestunit tests covering all URL getter methods (including suspend/resume). - Enable the JUnit Platform for the default
testtask inendtoendtests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
azurefunctions/src/main/java/com/microsoft/durabletask/azurefunctions/HttpManagementPayload.java |
Exposes suspend/resume POST management URLs via new getters. |
endtoendtests/src/test/java/com/functions/HttpManagementPayloadTest.java |
Adds unit tests to validate URL construction for all management endpoints. |
endtoendtests/build.gradle |
Configures the default Gradle test task to run on JUnit Platform. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
Enhancements to HTTP management endpoints:
getSuspendPostUri()andgetResumePostUri()to theHttpManagementPayloadclass, providing URLs for suspending and resuming orchestration instances.Testing improvements:
HttpManagementPayloadTest.javawith unit tests covering all URL generation methods inHttpManagementPayload, including the new suspend and resume endpoints.Build and test configuration:
endtoendtests/build.gradleto enable the JUnit Platform for running tests, ensuring compatibility with JUnit 5.Pull request checklist
CHANGELOG.md