Fix security-scan workflow: update CodeQL Action to v4, guard SARIF upload#493
Open
Fix security-scan workflow: update CodeQL Action to v4, guard SARIF upload#493
Conversation
…upload condition Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update CodeQL Action to version 4 in security workflow
Fix security-scan workflow: update CodeQL Action to v4, guard SARIF upload
Mar 3, 2026
IEvangelist
approved these changes
Mar 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the security-scan/security GitHub Actions workflow so it doesn’t fail when Trivy doesn’t generate a SARIF file, and it updates the deprecated CodeQL SARIF upload action to the current major version.
Changes:
- Add an
idto the Trivy step so later steps can reliably reference its result. - Gate SARIF upload on the Trivy step’s
outcometo avoid attempting uploads when Trivy failed to produce output. - Update
github/codeql-action/upload-sariffrom@v3to@v4.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
security-scan/securityjob fails when Trivy doesn't produce a SARIF file (e.g., on scan failure) because the upload step runs unconditionally viaalways(). Additionally, CodeQL Action v3 is deprecated.github/codeql-action/upload-sariffrom@v3→@v4id: trivyto the Trivy step and gate the upload onsteps.trivy.outcome == 'success'(outcomereflects the real result beforecontinue-on-erroris applied, unlikeconclusion)🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.