Harden contact path failover and simplify routing flow#1908
Open
robekl wants to merge 1 commit intomeshcore-dev:devfrom
Open
Harden contact path failover and simplify routing flow#1908robekl wants to merge 1 commit intomeshcore-dev:devfrom
robekl wants to merge 1 commit intomeshcore-dev:devfrom
Conversation
This was referenced Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reimplements and hardens PR #1777 behavior by introducing a conservative active/backup contact path model with safer failover and cleaner routing flow for embedded constraints.
Core behavior changes
direct_block_untilacross new path updates while block is still active.onContactPathUpdated()when active path actually changes (or is reset/failovered).Correctness and safety hardening
path_lendirectly as memcpy length.Packet::isValidPathLen) before route adoption.Refactors/simplifications included
isPathBetter).resetRouteFailoverState,resetAllRouteState).sendUsingBestRouteWithTxtAcksendUsingBestRouteNoTxtAcknowthrough relevant helpers to reduce repeated RTC reads and simplify temporal reasoning.Why this should be included
Benefits
Drawbacks / tradeoffs