Skip to content

feat(skills): enhance Verification-Before-Completion with MAXSIM integration#16

Open
maystudios wants to merge 1 commit intomainfrom
worktree-agent-a93f79eb
Open

feat(skills): enhance Verification-Before-Completion with MAXSIM integration#16
maystudios wants to merge 1 commit intomainfrom
worktree-agent-a93f79eb

Conversation

@maystudios
Copy link
Owner

Summary

  • Added context: fork to skill frontmatter for native Claude Code format
  • Replaced brief "In MAXSIM Plan Execution" section with comprehensive "Integration with MAXSIM" section covering context loading, plan verify/done block loading, STATE.md hooks, and artifact references

Test plan

  • Unit tests pass (54/54)
  • Full build succeeds
  • Lint passes

🤖 Generated with Claude Code

…e format and MAXSIM integration

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings March 2, 2026 04:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the “verification-before-completion” skill template to better describe how verification should be performed in MAXSIM-driven workflows, including a new frontmatter field intended for Claude Code compatibility.

Changes:

  • Added context: fork to the skill frontmatter.
  • Replaced the brief MAXSIM section with a more detailed “Integration with MAXSIM” guide (context loading, verify/done usage, STATE.md tracking, artifact references).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

When verifying within a MAXSIM project, load project context:

```bash
node ~/.claude/maxsim/bin/maxsim-tools.cjs skill-context verification-before-completion
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation instructs running maxsim-tools.cjs skill-context ..., but skill-context is not a supported maxsim-tools command (it doesn’t exist in the CLI command registry). This will fail for users; please update this section to use an existing command/workflow that provides the needed phase/plan context (or add/ship the missing command if that’s the intent).

Suggested change
node ~/.claude/maxsim/bin/maxsim-tools.cjs skill-context verification-before-completion
# From your MAXSIM project root, run the command your project uses
# to print the current phase, active plan path, and artifact locations.
# For example, you can inspect available commands with:
node ~/.claude/maxsim/bin/maxsim-tools.cjs --help

Copilot uses AI. Check for mistakes.
Comment on lines +131 to +132
- Load `.planning/phases/{current}/PLAN.md` for task `<verify>` blocks
- Surface `.planning/phases/{current}/VERIFICATION.md` if it exists — check prior verification results
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The artifact paths here don’t match MAXSIM’s established phase/plan naming conventions (plans are typically {phase}-{plan}-PLAN.md under .planning/phases/<phase_dir>/, and verification files are *-VERIFICATION.md). As written, .planning/phases/{current}/PLAN.md / .../VERIFICATION.md is likely to point to non-existent files; suggest documenting the glob/pattern or using the phase directory + plan filename returned by init/context commands.

Suggested change
- Load `.planning/phases/{current}/PLAN.md` for task `<verify>` blocks
- Surface `.planning/phases/{current}/VERIFICATION.md` if it exists — check prior verification results
- Load the plan file for the current phase (typically `{phase}-{plan}-PLAN.md` under `.planning/phases/<phase_dir>/`) for task `<verify>` blocks, using the phase directory and plan filename returned by MAXSIM init/context commands
- Surface any `*-VERIFICATION.md` file in the same phase directory, if it exists — check prior verification results

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants