Skip to content

Fix reversepropeller#121

Merged
ndem0 merged 8 commits intomasterfrom
fix_reversepropeller
Mar 5, 2026
Merged

Fix reversepropeller#121
ndem0 merged 8 commits intomasterfrom
fix_reversepropeller

Conversation

@DavideOberto
Copy link
Collaborator

Refactored the reversepropeller class:

  • generalized some code to handle different blades shapes and dimentions ;
  • generalized taking into account different topoDS shapes (compound, shells, faces) as starting blade's geometry;
  • defined four classes: i) an interface for reversepropeller; ii) a base class with the shared code; iii) reversepropeller for generic blades with old algorithm; ii) reversepropellerbladex for blades generated by BladeX. The latter implements a more robust algorithm that, however, exploits some assumptions on the geometry in the iges file and that cannot be trivially extended to reversepropeller;
  • added a tutorial on reversepropellerbladex.

@ndem0
Copy link
Member

ndem0 commented Mar 5, 2026

Thanks @DavideOberto, everything looks fine! Can you just run the tutorial and add it to the repo, along with the output cells?

@DavideOberto
Copy link
Collaborator Author

@ndem0 done!

@ndem0 ndem0 merged commit 0c84eab into master Mar 5, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants