Conversation
CatarinaGamboa
approved these changes
Mar 5, 2026
Collaborator
CatarinaGamboa
left a comment
CatarinaGamboa
left a comment
There was a problem hiding this comment.
great! with minor comment
| int b = pred.stop.getStopIndex(); | ||
| Interval interval = new Interval(a, b); | ||
| return input.getText(interval); | ||
| return pred.start.getInputStream().getText(interval); |
Collaborator
There was a problem hiding this comment.
should we worry about nulls here?
Collaborator
Author
There was a problem hiding this comment.
I don't think so, because this method is only called after a match with AliasContext, so both pred.start and getInputStream() are non-null.
rcosta358
force-pushed
the
improve-parser
branch
from
7a6c63e to
0318082
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the logic of the refinements parser to avoid repetition and improve readability.
Based on
improve-syntax-errors. After #166 is merged, the target branch should be changed tomain.