feat: adding TagDiscovery panel feature (#494)#502
feat: adding TagDiscovery panel feature (#494)#502EmanuelGF wants to merge 3 commits intolinkdotnet:masterfrom
Conversation
|
Reopened the PR after the accidental merge/reset. |
|
Taking over from the accidentially closed PR:
|
|
Thanks for the heads up @linkdotnet ! I noticed there are some issues with the tests related to the new dependencies I introduced, so I’ll work on fixing those. I can also address the remaining review suggestions from the previous PR. |
|
Addressed the remaining review suggestions given by @digitaldirk and fixed the failing tests related to the new dependencies. The Tag Discovery panel was also moved outside the navbar to prevent it from closing on resize. Can now be closed using escape key and display message when emply. Have a great weekend!! |
|
Awesome - looking already good. As we have a breaking change in the Basically adding an entry in the ctor here: https://github.com/linkdotnet/Blog/blob/master/tools/LinkDotNet.Blog.UpgradeAssistant/MigrationManager.cs#L17 And adding the logic next to here: https://github.com/linkdotnet/Blog/blob/master/tools/LinkDotNet.Blog.UpgradeAssistant/Migrations/Migration_11_To_12.cs |
digitaldirk
left a comment
There was a problem hiding this comment.
Awesome work, the issues and suggestions I had are fixed :)
Reopening the PR after the accidental merge and reset of master as discussed in #500.