Skip to content

Guard disk_timer_ to allow stop without start(). #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 2 commits into from
Mar 2, 2026
Merged

Guard disk_timer_ to allow stop without start(). #976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b804223
Remove dead code.
evoskuil Mar 2, 2026
2cebf25
Guard disk_timer_ to allow stop without start().
evoskuil Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ test_libbitcoin_node_test_SOURCES = \
test/error.cpp \
test/full_node.cpp \
test/main.cpp \
test/node.cpp \
test/settings.cpp \
test/test.cpp \
test/test.hpp \
Expand Down
1 change: 0 additions & 1 deletion builds/cmake/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,6 @@ if (with-tests)
"../../test/error.cpp"
"../../test/full_node.cpp"
"../../test/main.cpp"
"../../test/node.cpp"
"../../test/settings.cpp"
"../../test/test.cpp"
"../../test/test.hpp"
Expand Down
1 change: 0 additions & 1 deletion builds/msvc/vs2022/libbitcoin-node-test/libbitcoin-node-test.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@
<ClCompile Include="..\..\..\..\test\error.cpp" />
<ClCompile Include="..\..\..\..\test\full_node.cpp" />
<ClCompile Include="..\..\..\..\test\main.cpp" />
<ClCompile Include="..\..\..\..\test\node.cpp" />
<ClCompile Include="..\..\..\..\test\protocols\protocol.cpp" />
<ClCompile Include="..\..\..\..\test\sessions\session.cpp" />
<ClCompile Include="..\..\..\..\test\settings.cpp" />
Expand Down
3 changes: 0 additions & 3 deletions builds/msvc/vs2022/libbitcoin-node-test/libbitcoin-node-test.vcxproj.filters
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,6 @@
<ClCompile Include="..\..\..\..\test\main.cpp">
<Filter>src</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\test\node.cpp">
<Filter>src</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\test\protocols\protocol.cpp">
<Filter>src\protocols</Filter>
</ClCompile>
Expand Down
7 changes: 5 additions & 2 deletions src/chasers/chaser_storage.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,11 @@ void chaser_storage::stopping(const code& ec) NOEXCEPT
void chaser_storage::do_stopping(const code&) NOEXCEPT
{
BC_ASSERT(stranded());
disk_timer_->stop();
disk_timer_.reset();
if (disk_timer_)
{
disk_timer_->stop();
disk_timer_.reset();
}
}

// event handlers
Expand Down
28 changes: 0 additions & 28 deletions test/node.cpp
View file
Open in desktop

This file was deleted.

Loading