[Sistent] Add FormGroup component documentation to Sistent components page#7444
[Sistent] Add FormGroup component documentation to Sistent components page#7444shteypandey28-hue wants to merge 2 commits intolayer5io:masterfrom
Conversation
Amr-Shams
left a comment
Amr-Shams
left a comment
There was a problem hiding this comment.
Most of the changes here look like automatic linter/formatter updates (wrapping, spacing, etc.).
Also, make sure commits are signed (-s) and create an issue for this PR to follow conventions.
shteypandey28-hue
force-pushed
the
shrey-first-contribution
branch
from
468835f to
9735925
Compare
|
🚀 Preview for commit 9735925 at: https://69a576be23bcdc73d16e0d01--layer5.netlify.app |
|
Hi maintainers The FormGroup component documentation has been added, and all checks are now passing (DCO and build preview). Kindly requesting a review when you have time. |
| { id: 0, link: "/projects/sistent/getting-started/about", text: "About" }, | ||
| { id: 1, link: "/projects/sistent/getting-started/installation", text: "Installation" }, | ||
| { | ||
| id: 1, |
There was a problem hiding this comment.
this should be ignored when you try to commit
i recomend you use git restore --soft HEAD~1
and then use git add -p to selective the changes only
aka the form group content
| id: 20, | ||
| name: "Switch", | ||
| description: "The Switch component allows users to toggle the state of a single setting on or off.", | ||
| description: |
Amr-Shams
left a comment
Amr-Shams
left a comment
There was a problem hiding this comment.
just these changes and you are ready to go
|
🚀 Preview for commit 2ef6a54 at: https://69a599136a119d3d49c1a3bc--layer5.netlify.app |
shteypandey28-hue
force-pushed
the
shrey-first-contribution
branch
from
2ef6a54 to
36da9cb
Compare
|
🚀 Preview for commit 36da9cb at: https://69a5c38f4cc1525e0e366cc2--layer5.netlify.app |
|
@Amr-Shams The requested changes have been made , kindly review it and tell me if any further changes are needed. |
YASHMAHAKAL
left a comment
YASHMAHAKAL
left a comment
There was a problem hiding this comment.
@shteypandey28-hue latest preview isn't showing FormGroup component
|
🚀 Preview for commit 3e75442 at: https://69a604fb4cec936578a3c0b7--layer5.netlify.app |
|
kindly review it again and tell me if any further changes are needed. |
matrixkavi
left a comment
matrixkavi
left a comment
There was a problem hiding this comment.
Please ensure that you are changing only the lines you intend to change. A lot of changes are there in this PR as well as the next PR where you have added formatting related changes to js files. It can be cumbersome to review and can result in unwanted changes creeping in unknowingly.
@shteypandey28-hue - Could you please recheck? Because I do not think the changes have been made. Is it that you have a local commit that is not yet pushed? Also, as a good practice, while you are addressing reviews, please mark the review comments as resolved. It makes a re-review easier. |
|
@matrixkavi You can go check it and let the me know , it's been cleaned up now ! |
Signed-off-by: shteypandey28-hue <shteypandey28@gmail.com>
shteypandey28-hue
force-pushed
the
shrey-first-contribution
branch
from
3e75442 to
248873c
Compare
Signed-off-by: shteypandey28-hue <shteypandey28@gmail.com>
|
🚀 Preview for commit 2e8a4eb at: https://69a6f79635189f1545b7188c--layer5.netlify.app |
5 participants
Description
This PR adds the FormGroup component documentation to the Sistent components section.
The following has been implemented:
Changes Made
src/sections/Projects/Sistent/components/formgroup/index.jsguidance.jscode.jssrc/pages/projects/sistent/components/formgroup/SistentNavigation/content.jscomponents/content.jsVerification
npm run develop/projects/sistent/components/formgroup/projects/sistent/components/formgroup/guidance/projects/sistent/components/formgroup/code