fix: e2e test naming to match category conventions + add verbose flag to 'func subscribe'#3473
Open
gauron99 wants to merge 1 commit intoknative:mainfrom
Open
fix: e2e test naming to match category conventions + add verbose flag to 'func subscribe'#3473gauron99 wants to merge 1 commit intoknative:mainfrom
gauron99 wants to merge 1 commit intoknative:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
approved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3473 +/- ##
==========================================
+ Coverage 54.71% 54.76% +0.04%
==========================================
Files 181 181
Lines 20436 20437 +1
==========================================
+ Hits 11182 11192 +10
+ Misses 8074 8066 -8
+ Partials 1180 1179 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
apparently it doesn't like |
gauron99
force-pushed
the
push-loxmtzpqkxut
branch
from
4b7c272 to
9047362
Compare
knative-prow
bot
added
size/M
gauron99
changed the title
gauron99
requested review from
lkingland and
matejvasek
and removed request for
dsimansk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some e2e test never actually ran!... fix this for e2e scripts accept a naming convention
Had to create a verbose flag for
func subscribesince it was lacking the implementation as well