Skip to content

Fix flattened mapping keys #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidesner wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix flattened mapping keys #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c4b05d
Fix flattened mapping keys
davidesner Nov 18, 2023
726ffda
Automated html docs build
Nov 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions docs/mapping.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@ <h1 class="title">Module <code>keboola.json_to_csv.mapping</code></h1>

for child_key, child_mapping in mapping.child_tables.items():
# TODO: use dynamic separator
key = f&#39;{key}_{child_key}&#39;
flat_mappings.update(_flatten_mapping(child_mapping, key))
new_key = f&#39;{key}_{child_key}&#39;
flat_mappings.update(_flatten_mapping(child_mapping, new_key))

return flat_mappings

Expand Down Expand Up @@ -283,8 +283,8 @@ <h2 id="attributes">Attributes</h2>

for child_key, child_mapping in mapping.child_tables.items():
# TODO: use dynamic separator
key = f&#39;{key}_{child_key}&#39;
flat_mappings.update(_flatten_mapping(child_mapping, key))
new_key = f&#39;{key}_{child_key}&#39;
flat_mappings.update(_flatten_mapping(child_mapping, new_key))

return flat_mappings

Expand Down Expand Up @@ -567,8 +567,8 @@ <h3>Methods</h3>

for child_key, child_mapping in mapping.child_tables.items():
# TODO: use dynamic separator
key = f&#39;{key}_{child_key}&#39;
flat_mappings.update(_flatten_mapping(child_mapping, key))
new_key = f&#39;{key}_{child_key}&#39;
flat_mappings.update(_flatten_mapping(child_mapping, new_key))

return flat_mappings

Expand Down
4 changes: 2 additions & 2 deletions src/keboola/json_to_csv/mapping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ def _flatten_mapping(mapping: 'TableMapping', key='') -> Dict:

for child_key, child_mapping in mapping.child_tables.items():
# TODO: use dynamic separator
key = f'{key}_{child_key}'
flat_mappings.update(_flatten_mapping(child_mapping, key))
new_key = f'{key}_{child_key}'
flat_mappings.update(_flatten_mapping(child_mapping, new_key))

return flat_mappings

Expand Down