Skip to content

sdk: bump golang to 1.25.7#137

Closed
gman0 wants to merge 1 commit intokcp-dev:mainfrom
gman0:sdk-bump-go-1.25.7
Closed

sdk: bump golang to 1.25.7#137
gman0 wants to merge 1 commit intokcp-dev:mainfrom
gman0:sdk-bump-go-1.25.7

Conversation

@gman0
Copy link
Contributor

@gman0 gman0 commented Mar 3, 2026

Summary

Bump golang to 1.25.7 in the sdk module.

What Type of PR Is This?

/kind bug

Related Issue(s)

Part of #134

Release Notes

NONE

On-behalf-of: @SAP robert.vasek@sap.com
Signed-off-by: Robert Vasek <robert.vasek@clyso.com>
@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Mar 3, 2026
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign embik for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 3, 2026
@gman0
Copy link
Contributor Author

gman0 commented Mar 3, 2026

/retest

@xrstf
Copy link
Contributor

xrstf commented Mar 3, 2026

I disagree with this change. The SDK should have the lowest compatible version listed, to increase its usefulness to consumers. Forcing everyone who imports our SDK onto a newer, and in this case even specific, Go version is IMHO the wrong approach. Just like the dependencies in the SDK should be the oldest compatible versions the SDK can work with.

@xrstf
Copy link
Contributor

xrstf commented Mar 3, 2026

In general I think bumping the Go version in the go.mod is often a futile exercise with little to no real meaning for the actual build artifacts. ^^ The go version shows what Go release is required to build the code, not necessarily which version is actually used to compile it.

@gman0
Copy link
Contributor Author

gman0 commented Mar 3, 2026

Sounds reasonable, closing.

@gman0 gman0 closed this Mar 3, 2026
@gman0 gman0 deleted the sdk-bump-go-1.25.7 branch March 3, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants