Conversation
On-behalf-of: @SAP robert.vasek@sap.com Signed-off-by: Robert Vasek <robert.vasek@clyso.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
|
I disagree with this change. The SDK should have the lowest compatible version listed, to increase its usefulness to consumers. Forcing everyone who imports our SDK onto a newer, and in this case even specific, Go version is IMHO the wrong approach. Just like the dependencies in the SDK should be the oldest compatible versions the SDK can work with. |
|
In general I think bumping the Go version in the go.mod is often a futile exercise with little to no real meaning for the actual build artifacts. ^^ The go version shows what Go release is required to build the code, not necessarily which version is actually used to compile it. |
|
Sounds reasonable, closing. |
Summary
Bump golang to 1.25.7 in the
sdkmodule.What Type of PR Is This?
/kind bug
Related Issue(s)
Part of #134
Release Notes