Milestones module development by phansier · Pull Request #343 · jonan/ForkHub

phansier · 2018-02-08T20:40:05Z

Created:

List view of all repository milestones
Milestone view page
Milestone edit/create page
Dialog to add issue to milestone
Menu element to open milestones list
Milestones API support using Retofit

Made other changes related to Milestones

Changed some russian (ru) localisation strings.

Added layouts Added menu items Added classes, activities, fragments

#7 Closed

Milestones list view

Remove redundant code

CRUD milestones

Create and edit milestone

View include: - title - due to date - description - progress - back to milestones list button

…Ber/ForkHub into iss8_milestine_view_page

Fixed the test

Added milestone support in old issue class

Fragment replace with updated milestone

Remove unnecessary string (login_or_email)

#39 translations

Merge commits from Jonan repository

Split layouts for different places

jonan

I haven't tested everything yet, but I've added a few comments so you can start working on it if you want.

app/src/main/res/values-bg/strings.xml

jonan · 2018-02-16T12:31:42Z

app/src/main/res/values-ru/strings.xml

    <string name="error_gists_load">Ошибка при загрузке Gists</string>
    <string name="error_issue_load">Ошибка при загрузке задачи</string>
    <string name="error_collaborators_load">Ошибка при загрузке соучастников</string>
-    <string name="error_milestones_load">Ошибка при загрузке целей</string>


Don't update all the RU strings in this PR. You can send a new PR with this changes, but limit this one to just the new strings.

Fixed in phansier@e3a85c2
If OK, will be merged to PR

jonan · 2018-02-16T12:40:59Z

app/src/main/java/com/github/mobile/GitHubModule.java

+                new Moshi.Builder().add(new DateAdapter()).build().adapter(Milestone.class).serializeNulls();
        Moshi converter = new Moshi.Builder()
                .add(new DateAdapter())
+                .add(Milestone.class, adapter)


Why do you need a custom adapter for milestones?

To allow setting null due_date for milestone

Can't you achieve the same result by modifying the current DateAdapter?

No, default adapter for milestones just ignores null properties.
So there is no other way to send patch request with due_on = null.

No, I mean changing the behavior of https://github.com/jonan/ForkHub/blob/master/app/src/main/java/com/github/mobile/api/DateAdapter.java which is already being used.

If we set due_on = null, then DateAdapter is not being called by Milestone adapter because it skips null properties.
Yes, we can achieve it only with DateAdapter, if use some date as null. For example, DateAdapter will replace 01/01/1990 to null. But I am not sure, that it is a better alternative.

jonan · 2018-02-16T12:49:45Z

app/src/androidTest/java/com/github/mobile/tests/issue/IssueFilterTest.java

+        filter1.setMilestone(extraMilestone);
        assertFalse(filter1.equals(filter2));
-        filter2.setMilestone(milestone);
+        filter2.setMilestone(extraMilestone);


This should be done removing the old org.eclipse.egit.github.core.Milestone code, simply creating the milestone with the new model object.

Fixed in phansier@9e5ae56
If OK, will be merged to PR

jonan · 2018-02-16T12:52:10Z

app/src/main/java/com/github/mobile/api/model/Issue.java

+        if (milestone != null){
+            issue.setMilestone(milestone.getOldModel());
+        }
+


Whitespace missing before { 😉
And please remove last line break for consistency.

Fixed in phansier@30048f0
If OK, will be merged to PR

jonan · 2018-02-20T12:10:02Z

app/src/main/java/com/github/mobile/api/service/MilestoneService.java

+    Call<List<Issue>> getIssues(
+            @Path("owner") String owner,
+            @Path("repo") String repo,
+            @Query("milestone") long milestone);


More pagination problems.

We prefer to fix it in future because it is not the vital problem for milestones

app/src/main/java/com/github/mobile/ui/issue/IssuesViewActivity.java

jonan · 2018-02-21T16:08:49Z

app/src/main/res/menu/repository.xml

+    <item
+        android:id="@+id/m_milestone"
+        app:showAsAction="never"
+        android:title="@string/milestone"/>


We should probably use the plural "Milestones" here.

Fixed in phansier@f493fe9
If OK, will be merged to PR

jonan · 2018-02-21T16:14:25Z

app/src/main/java/com/github/mobile/ui/issue/MilestoneDialogFragment.java

-            else
-                setGone(2, true);
-
-            setChecked(0, selected == position);


Why delete this code?
You're breaking the issue filtering by milestone

Fixed together with UI fixes phansier@d3658ad
If OK, will be merged to PR

app/src/main/java/com/github/mobile/ui/issue/EditIssuesFilterActivity.java

Ui changes

PR comments fix

… into pr_comments_fix

Revert Incorrect transition between issue and milestone activities

arepina and others added 30 commits November 21, 2017 22:50

Started implementation of create and edit function

081cf03

Added layouts Added menu items Added classes, activities, fragments

Add List view of all repository milestones

ae5596c

#7 Closed

Milestones list localization

2d6fe3f

Add create milestone button

2c8f445

Add mock for click on milestone

56e2ae2

Merge pull request #44 from AndreySBer/milestones_list_view

970e2d0

Milestones list view

Opening create milestone page by plus

f7ba846

Added date picker

e2a05c3

Added 2 weeks and 1 month

0f89372

Milestones Service

1d4b946

Fixed the dates in piker

3c2e2f3

CreateMilestoneTask

97ef560

Display closed milestone in repo

177aff9

Remove redundant code

EditMilestone Task

f789379

Change Headers in MilestoneService

fcff329

Delete milestone in MilestoneService

61d168e

Chage tag in editMilestone

fe86c30

DeleteMilestone task

095bbf9

Add localisation for RU edit milestone

be4ea89

Fix NPE crash on milestone edit page

e98304c

Fix layout

a49d793

Merge pull request #46 from AndreySBer/feature_milestones_api_interface

25634e3

CRUD milestones

Refactor adding 1 month

46b674a

Merge pull request #47 from AndreySBer/create_and_edit_milestone

7f9bcc3

Create and edit milestone

mockup classes

98123ee

Initial detailed milestone view

3e97b5c

View include: - title - due to date - description - progress - back to milestones list button

Styles added to milestone view

cd188da

Return gradle properties back

bc378c7

Merge branch 'iss8_milestine_view_page' of https://github.com/AndreyS…

2fe6404

…Ber/ForkHub into iss8_milestine_view_page

Displaying closed issues in milestone

6e2c675

phansier and others added 14 commits February 7, 2018 22:36

Fix crashes found by ui tests

cf31ab7

Merge pull request #98 from AndreySBer/test_run

e860b82

Fixed the test

Added milestone support in old issue class

c57c96b

Fragment replace with updated milestone.

fd6a50a

Merge pull request #100 from AndreySBer/bugfix-73-milestoneNotDisplaying

e518b7c

Added milestone support in old issue class

Merge pull request #101 from AndreySBer/bugfix-88-filterNotUpdating

e4602e6

Fragment replace with updated milestone

Fix & add russian translations

baa1bd8

Remove unnecessary string (login_or_email)

Change milestone translation in RU on more appropriate

4cc54a6

Hotfix milestone translation in RU on more appropriate

00d3e2b

Merge pull request #102 from AndreySBer/#39_translations

cd41a4a

#39 translations

Merge pull request #26 from jonan/master

6e47980

Merge commits from Jonan repository

Milestone list

bf37592

Dialog issue list

ab0329d

Split layouts for different places

Allign buttons on Milestone edit

c4d3159

jonan requested changes Feb 21, 2018

View reviewed changes

phansier and others added 11 commits February 23, 2018 23:22

Revert: Remove unnecessary string (login_or_email)

4b87e74

Revert: Change milestone translation in RU on more appropriate

e3a85c2

Use new Milestone model in IssueFilterTest

9e5ae56

Fix Whitespace missing before {

30048f0

Remove comments about Milestone new to old model mapping issues

0883b55

Make use the plural "Milestones" here (ru+en locals)

f493fe9

Revert: return issue filtering code

d3658ad

Avoid NPE in getting old milestone

19d4db3

Remove redundant headers

f2044a2

Merge pull request #105 from AndreySBer/ui_changes

42f616c

Ui changes

Merge pull request #104 from AndreySBer/pr_comments_fix

d2b391c

PR comments fix

phansier mentioned this pull request Feb 27, 2018

Incorrect transition between issue and milestone activities phansier/ForkHub#71

Closed

phansier added 3 commits March 5, 2018 11:24

Revert Incorrect transition between issue and milestone activities

68a24e6

Merge branch 'pr_comments_fix' of https://github.com/AndreySBer/ForkHub…

f60a50e

… into pr_comments_fix

Merge pull request #107 from AndreySBer/pr_comments_fix

4b38c89

Revert Incorrect transition between issue and milestone activities

Conversation

phansier commented Feb 8, 2018

Uh oh!

jonan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants