fix #1120, fix out of bound access.#1121
Closed
caogtaa wants to merge 1 commit intoincrepare:masterfrom
Closed
Conversation
Owner
|
yes this change is good - I had to work so hard to understand the bitvec code I decided to basically just rewrite a lot of bitvec code again to make it clearer and forgot than to pull your change request first ( d8e1d5d ). But the contents are in. Thank you for the very smart bug report + fix. Generating fewer instructions in the inner loop is a win :) |
Contributor
Author
Good to hear that :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1120 .
If shift count is no more than 27, no need to access next int32.