feat(js-host-api): add npm publishing workflow#36
Open
simongdavies wants to merge 1 commit intomainfrom
Open
Conversation
- Add npm-publish.yml workflow for cross-platform builds (Linux/Windows x64) - Add platform-specific npm packages for native binaries - Integrate npm publish into CreateRelease workflow - Add .npmignore to control published files - Update README with publishing documentation
jprendes
approved these changes
Mar 4, 2026
Contributor
jprendes
left a comment
jprendes
left a comment
There was a problem hiding this comment.
LGTM, it would be great if we could test it in a local repo before publishing to npm, to make sure that it works as expected. There is a lot of nodejs magic in here :-)
| required: false | ||
| type: boolean | ||
| default: false | ||
| secrets: |
Contributor
There was a problem hiding this comment.
Do we need secrets in workflow_dispatch too? or does this cover both?
| "binaryName": "js-host-api" | ||
| "binaryName": "js-host-api", | ||
| "targets": [ | ||
| "x86_64-unknown-linux-gnu", |
Comment on lines
+23
to
+26
| "optionalDependencies": { | ||
| "@hyperlight/js-host-api-linux-x64-gnu": "0.17.0", | ||
| "@hyperlight/js-host-api-win32-x64-msvc": "0.17.0" | ||
| }, |
Contributor
There was a problem hiding this comment.
A link to the napi-rs explaining how this would would be helpful (at least for future me), although I think we can't put comments in package.json, right? :-(
https://napi.rs/docs/deep-dive/release#3-the-native-addon-for-different-platforms-is-distributed-through-different-npm-packages
Also, that link seems to imply that you need "os" and "cpu" fields in this package as well, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds cross-platform npm publishing for
@hyperlight/js-host-api.Changes
Usage
release/vX.Y.ZbranchesSetup Required
Add
NPM_TOKENsecret (npm access token with publish permissions for@hyperlightscope)