CI: build with hidden symbols using Clang#1675
Merged
rustam-gamidov-here merged 3 commits intofeature_boost_jsonfrom Mar 3, 2026
Merged
CI: build with hidden symbols using Clang#1675rustam-gamidov-here merged 3 commits intofeature_boost_jsonfrom
rustam-gamidov-here merged 3 commits intofeature_boost_jsonfrom
Conversation
Good to able to do this. No tests as not exposed classes are accessed in tests Relates-To: MINOR Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature_boost_json #1675 +/- ##
=====================================================
Coverage ? 80.37%
=====================================================
Files ? 351
Lines ? 14068
Branches ? 1516
=====================================================
Hits ? 11306
Misses ? 2148
Partials ? 614 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8113b2e to
fffbe29
Compare
To utilize in the common binary Relates-To: MINOR Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
Otherwise there are unresolved external symbols when built with visibility=hidden Relates-To: MINOR Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
fffbe29 to
01c91fb
Compare
andrey-kashcheev
approved these changes
Mar 3, 2026
ystefinko
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good to able to do this.
No tests as not exposed classes are accessed in tests