Open
Conversation
Icelandjack
force-pushed
the
generically
branch
from
115bce2 to
34264ac
Compare
Collaborator
|
I have rebased this and fixed a few minor wibbles. |
konsumlamm
reviewed
Mar 4, 2026
Contributor
konsumlamm
left a comment
konsumlamm
left a comment
There was a problem hiding this comment.
Could you rebase on latest master?
| -- and then deriving the appropriate @'Binary' T@ instance via | ||
| -- @Generically T@. | ||
| -- | ||
| -- > {-# LANGUAGE DeriveAnyClass #-} |
Contributor
There was a problem hiding this comment.
I don't think DeriveAnyClass is needed here.
| -- | ||
| -- This mechanism makes use of GHC's efficient built-in generics | ||
| -- support. | ||
| -- Beginning with GHC 7.2 this generic definition has been a part of |
Contributor
There was a problem hiding this comment.
Suggested change
| -- Beginning with GHC 7.2 this generic definition has been a part of | |
| -- Beginning with GHC 7.2, a generic definition has been a part of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binary (Generically a)instance.