Backport some issues with offchain vids#6417
Open
lutter wants to merge 2 commits intokrishna/cherry-pick-anynetworkbarefrom
Open
Backport some issues with offchain vids#6417lutter wants to merge 2 commits intokrishna/cherry-pick-anynetworkbarefrom
lutter wants to merge 2 commits intokrishna/cherry-pick-anynetworkbarefrom
Conversation
…ame block (#6336) * fix: thread vid_seq across offchain triggers to prevent duplicate VIDs When specVersion >= 1.3.0, VIDs are computed deterministically as (block_number << 32) + vid_seq. Each offchain trigger in handle_offchain_triggers creates a fresh EntityCache with vid_seq reset to RESERVED_VIDS (100). When multiple file data source triggers fire in the same block and write to the same entity table, they produce identical VIDs, causing PostgreSQL primary key violations: "duplicate key value violates unique constraint task_metadata_pkey" Fix: Pass the onchain EntityCache's final vid_seq into handle_offchain_triggers and accumulate it across loop iterations, so each offchain trigger continues the sequence from where the previous one left off. * test: add unit tests proving VID collision bug in offchain triggers Two tests demonstrate the bug where multiple offchain triggers (e.g. file data sources) in the same block each create a fresh EntityCache with vid_seq reset to RESERVED_VIDS (100), producing duplicate VIDs that violate the primary key constraint. - offchain_trigger_vid_collision_without_fix: proves VIDs collide - offchain_trigger_vid_no_collision_with_fix: proves threading vid_seq across triggers prevents collisions * refactor: improve comment clarity in vid_seq threading * test-store: Fix rustfmt style in entity_cache tests
Each ipfs.map() callback created a fresh BlockState with vid_seq reset to RESERVED_VIDS. When multiple callbacks write to the same entity table, they all generate vids starting at (block<<32)+100, producing duplicates. Fix by threading vid_seq through the callback loop and updating it in EntityCache::extend() so the parent handler also continues from the right sequence after merging callback results.
incrypto32
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.