feat(helm): support global.imageRegistry#4866
Open
okhowang wants to merge 1 commit intografana:mainfrom
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes how the container image reference is constructed in the core deployment template, which can affect all installs if existing
image.repositoryvalues included a registry or relied on the old image format.Overview
Adds a chart-level
global.imageRegistryvalue and updates the workload template to build the Pyroscope image as(<global.imageRegistry> | <pyroscope.image.registry>)/<pyroscope.image.repository>:<tag>.This enables globally overriding the Docker registry (defaulting to
docker.io) while keeping per-chartrepository/tagcontrols the same.Written by Cursor Bugbot for commit df04916. This will update automatically on new commits. Configure here.