Skip to content

chore: skip ITQueueTest in cloud-devel#4374

Merged
sakthivelmanii merged 1 commit intomainfrom
chore/skip-itqueue-test
Mar 4, 2026
Merged

chore: skip ITQueueTest in cloud-devel#4374
sakthivelmanii merged 1 commit intomainfrom
chore/skip-itqueue-test

Conversation

@sakthivelmanii
Copy link
Collaborator

This PR temporarily skips the ITQueueTest in the cloud-devel environment because the Cloud Spanner Queues feature is not supported and throws UNIMPLEMENTED errors.

Test failure log: https://fusion2.corp.google.com/invocations/d878e622-09d6-4f00-89a6-52c4fd58e422

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes test failure ☕️

If you write sample code, please follow the samples format.

@sakthivelmanii sakthivelmanii requested review from a team as code owners March 4, 2026 10:29
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/java-spanner API. labels Mar 4, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a recurring test failure in the cloud-devel environment by temporarily disabling an integration test (ITQueueTest). The test relies on the Cloud Spanner Queues feature, which is currently unsupported in cloud-devel, leading to UNIMPLEMENTED errors. This change ensures the test suite passes in the specified environment until the feature is fully enabled.

Highlights

  • Test Skipping: Temporarily disabled the ITQueueTest in the cloud-devel environment.
  • Reason for Skipping: The Cloud Spanner Queues feature, which ITQueueTest relies on, is not supported in cloud-devel and throws UNIMPLEMENTED errors.
  • Impact: Fixes a test failure in the cloud-devel environment, allowing the test suite to pass.
Changelog
  • google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITQueueTest.java
    • Modified the assumeTrue condition in the setUpTestSuite method to skip the test when running in the cloud-devel environment.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@sakthivelmanii sakthivelmanii force-pushed the chore/skip-itqueue-test branch from 05d6f59 to cfb75c2 Compare March 4, 2026 10:32
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Mar 4, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly implements the temporary skipping of ITQueueTest in the cloud-devel environment, addressing the UNIMPLEMENTED errors for Cloud Spanner Queues as described. The change effectively reverses the condition for test execution, ensuring the test is skipped where the feature is not yet supported.

@sakthivelmanii sakthivelmanii force-pushed the chore/skip-itqueue-test branch from cfb75c2 to 2e5579b Compare March 4, 2026 10:45
@sakthivelmanii sakthivelmanii merged commit 0bf87a3 into main Mar 4, 2026
51 of 57 checks passed
@sakthivelmanii sakthivelmanii deleted the chore/skip-itqueue-test branch March 4, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants