chore: skip ITQueueTest in cloud-devel#4374
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a recurring test failure in the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
05d6f59 to
cfb75c2
Compare
There was a problem hiding this comment.
Code Review
This pull request correctly implements the temporary skipping of ITQueueTest in the cloud-devel environment, addressing the UNIMPLEMENTED errors for Cloud Spanner Queues as described. The change effectively reverses the condition for test execution, ensuring the test is skipped where the feature is not yet supported.
cfb75c2 to
2e5579b
Compare
This PR temporarily skips the
ITQueueTestin thecloud-develenvironment because the Cloud Spanner Queues feature is not supported and throwsUNIMPLEMENTEDerrors.Test failure log: https://fusion2.corp.google.com/invocations/d878e622-09d6-4f00-89a6-52c4fd58e422
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes test failure ☕️
If you write sample code, please follow the samples format.