Skip to content

chore(librarian): update configuration for google-cloud-firestore#16024

Merged
ohmayr merged 1 commit intomainfrom
fix-google-cloud-firestore
Mar 4, 2026
Merged

chore(librarian): update configuration for google-cloud-firestore#16024
ohmayr merged 1 commit intomainfrom
fix-google-cloud-firestore

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Mar 4, 2026

Generation for google-cloud-firestore failed in #16023 because of failed check that was added in #14441. The library had an incorrect distribution name in setup.py. The generation process for google-cloud-python packages with multiple API versions/sub-packages relies on the order of entries in the apis list. Since each API path generates a setup.py and the last one processed takes precedence, the previous ordering caused the package to be incorrectly named google-cloud-firestore-admin instead of the expected google-cloud-firestore.

This PR moves google/firestore/v1 to the bottom of the apis list, resulting in the correct package name in the generated setup.py.

See related issue googleapis/librarian#4205

@parthea parthea requested review from a team as code owners March 4, 2026 22:29
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue in the google-cloud-firestore package generation process. Previously, an incorrect ordering of API entries led to the package being misnamed in setup.py. By adjusting the sequence of API paths in the configuration, this change ensures that the setup.py file is generated with the correct package name, thereby fixing the build failure and ensuring proper distribution.

Highlights

  • Configuration Update: Reordered API paths for google-cloud-firestore in .librarian/state.yaml to resolve an incorrect package name generation issue.
Changelog
  • .librarian/state.yaml
    • Moved the google/firestore/v1 API path entry to the end of the apis list for google-cloud-firestore.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a critical issue where the google-cloud-firestore package was incorrectly named google-cloud-firestore-admin due to the processing order of API paths during generation. By reordering the apis list in .librarian/state.yaml to place google/firestore/v1 last, the change ensures that the correct package name takes precedence. This is a targeted and effective fix for the described problem, resolving the generation failure.

@ohmayr ohmayr merged commit af65c0d into main Mar 4, 2026
27 checks passed
@ohmayr ohmayr deleted the fix-google-cloud-firestore branch March 4, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants