Skip to content

fix: Allow protobuf 7.x#2575

Merged
parthea merged 2 commits intogoogleapis:mainfrom
rfrerebe-stx:main
Mar 4, 2026
Merged

fix: Allow protobuf 7.x#2575
parthea merged 2 commits intogoogleapis:mainfrom
rfrerebe-stx:main

Conversation

@rfrerebe-stx
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [✅ ] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • [✅ ] Ensure the tests and linter pass
  • [ ✅] Code coverage does not decrease (if any source code was changed)
  • [ ✅] Appropriate docs were updated (if necessary)

Fixes #2574 🦕

@rfrerebe-stx rfrerebe-stx requested a review from a team as a code owner March 4, 2026 12:40
@google-cla
Copy link

google-cla bot commented Mar 4, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Mar 4, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request broadens the acceptable version range for the "protobuf" library within the project's dependency configurations. By allowing "protobuf" versions up to 7.x, it resolves a specific issue (#2574) and ensures that generated client libraries and the generator itself can integrate with newer "protobuf" releases without strict version conflicts, thereby enhancing flexibility and maintainability.

Highlights

  • Dependency Management: The upper bound for the "protobuf" dependency has been relaxed from "<7.0.0" to "<8.0.0" across all relevant "setup.py" files and Jinja2 templates, enabling compatibility with "protobuf" 7.x.
Changelog
  • gapic/ads-templates/setup.py.j2
    • Updated the "protobuf" dependency constraint to allow versions up to "<8.0.0".
  • gapic/templates/setup.py.j2
    • Updated the "protobuf" dependency constraint to allow versions up to "<8.0.0".
  • setup.py
    • Updated the "protobuf" dependency constraint to allow versions up to "<8.0.0".
  • tests/integration/goldens/asset/setup.py
    • Updated the "protobuf" dependency constraint to allow versions up to "<8.0.0".
  • tests/integration/goldens/credentials/setup.py
    • Updated the "protobuf" dependency constraint to allow versions up to "<8.0.0".
  • tests/integration/goldens/eventarc/setup.py
    • Updated the "protobuf" dependency constraint to allow versions up to "<8.0.0".
  • tests/integration/goldens/logging/setup.py
    • Updated the "protobuf" dependency constraint to allow versions up to "<8.0.0".
  • tests/integration/goldens/logging_internal/setup.py
    • Updated the "protobuf" dependency constraint to allow versions up to "<8.0.0".
  • tests/integration/goldens/redis/setup.py
    • Updated the "protobuf" dependency constraint to allow versions up to "<8.0.0".
  • tests/integration/goldens/redis_selective/setup.py
    • Updated the "protobuf" dependency constraint to allow versions up to "<8.0.0".
Activity
  • The author confirmed that all pre-submission checks, including tests, linter, code coverage, and documentation updates, have passed.
  • This pull request directly addresses and resolves issue Allow protobuf 7.x #2574.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the protobuf dependency constraint to <8.0.0 in setup.py, Jinja2 templates, and golden test files, to allow for protobuf version 7.x. The changes are consistent across all modified files. My review found no issues to report.

@parthea parthea changed the title Allow protobuf 7.x fix: Allow protobuf 7.x Mar 4, 2026
Copy link
Contributor

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parthea
Copy link
Contributor

parthea commented Mar 4, 2026

Thanks @rfrerebe-stx!

@parthea parthea merged commit 98137d0 into googleapis:main Mar 4, 2026
212 of 217 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow protobuf 7.x

4 participants