Change helm defaults to be more newcomer friendly#919
Open
tylerohlsen wants to merge 12 commits intogithub:main-enterprisefrom
Open
Change helm defaults to be more newcomer friendly#919tylerohlsen wants to merge 12 commits intogithub:main-enterprisefrom
tylerohlsen wants to merge 12 commits intogithub:main-enterprisefrom
Conversation
…nside the container
Contributor
Author
|
@decyjphr sorry for the ping, but would you be able to look this over this change? |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Helm chart defaults to make first-time installs less surprising and to align the chart with how the safe-settings container actually runs (Fixes #918).
Changes:
- Fix Deployment
containerPortto always be3000(independent ofservice.port). - Make defaults more cost-effective by setting
replicaCountand HPAminReplicasto1. - Make
deploymentConfigexamples opt-in by defaulting validators to empty lists and commenting example entries; add commented examples for required env vars.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| helm/safe-settings/values.yaml | Updates defaults (replicas/HPA), adds commented env examples, and changes validator/include defaults. |
| helm/safe-settings/templates/deployment.yaml | Fixes containerPort to 3000 so Service/Ingress ports don’t incorrectly change the container port. |
| helm/safe-settings/README.md | Updates the values table to match the new defaults (replicas/minReplicas/service.port/validator defaults). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #918