Skip to content

Add JavaScript support to code scanning workflow #2157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattdholloway merged 1 commit into from
Mar 6, 2026
Merged

Add JavaScript support to code scanning workflow #2157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/code-scanning.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ jobs:
category: /language:go
build-mode: autobuild
runner: '["ubuntu-22.04"]'
- language: javascript
category: /language:javascript
build-mode: none
runner: '["ubuntu-22.04"]'
Comment on lines +38 to +41
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The matrix adds javascript with build-mode: none, but the workflow still runs the github/codeql-action/autobuild@v4 step unconditionally. This means the new JavaScript job will execute an unnecessary (and potentially flaky) autobuild phase even though the job declares no build. Consider either (a) gating the Autobuild step on matrix.build-mode == 'autobuild', or (b) switching the JavaScript entry to build-mode: autobuild and adding explicit npm install/build steps so the build behavior is intentional and consistent.

Copilot uses AI. Check for mistakes.
steps:
- name: Checkout repository
uses: actions/checkout@v6
Expand Down Expand Up @@ -75,7 +79,7 @@ jobs:
cache: false

- name: Set up Node.js
if: matrix.language == 'go'
if: matrix.language == 'go' || matrix.language == 'javascript'
uses: actions/setup-node@v4
with:
node-version: "20"
Expand Down