fix: handle lightweight tags in get_tag tool#2137
Open
fidesit wants to merge 2 commits intogithub:mainfrom
Open
fix: handle lightweight tags in get_tag tool#2137fidesit wants to merge 2 commits intogithub:mainfrom
fidesit wants to merge 2 commits intogithub:mainfrom
Conversation
Lightweight tags point directly to commits, not tag objects. The get_tag tool previously always called the Git Tag API which returns 404 for lightweight tags since their SHA references a commit, not a tag object. Now checks ref.Object.Type: if "commit" (lightweight), resolves the commit directly and returns a tag-like structure for consistency. If "tag" (annotated), proceeds with the existing tag object fetch.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes get_tag so it works with both annotated and lightweight Git tags by avoiding the Git Tag Object API for lightweight tags (which point directly to commits and otherwise 404).
Changes:
- Branch on
ref.Object.TypeafterGit.GetRef()to distinguish annotated ("tag") vs lightweight ("commit") tags. - For lightweight tags, fetch the commit via
Git.GetCommit()and return agithub.Tag-compatible payload. - Extend
Test_GetTagwith fixtures and a new “successful lightweight tag retrieval” test case.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
pkg/github/repositories.go |
Adds lightweight-tag handling by resolving commit refs and returning a tag-like JSON payload. |
pkg/github/repositories_test.go |
Adds mocks and a new test case covering lightweight tag retrieval. |
Address Copilot review comments: - Use distinct variable names (refResp, commitResp, tagResp) for each API response to avoid defer closure capturing issues with shared resp. - Add 'lightweight tag commit not found' error test case for GetCommit returning 404. - Assert Tagger field mapping (author -> tagger) in the lightweight tag success test case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
get_tagtool returns a 404 error when used with lightweight tags because it unconditionally calls the Git Tag Object API, which only works for annotated tags.ref.Object.Typecheck after resolving the tag reference"commit"type): resolves viaGit.GetCommit()and returns agithub.Tag-compatible structure"tag"type): unchanged behavior viaGit.GetTag()Bug
In
pkg/github/repositories.go, theGetTaghandler resolves a tag reference viaclient.Git.GetRef(), then always callsclient.Git.GetTag()with the ref's SHA. This works for annotated tags (where the SHA points to a tag object), but fails for lightweight tags (where the SHA points directly to a commit — the Git Tag Object API returns 404).Reproduce: Create a lightweight tag (
git tag v1.0.0 && git push --tags), then callget_tag→ 404.Changes
pkg/github/repositories.goref.Object.Type"commit"(lightweight): callclient.Git.GetCommit(), return agithub.Tagstruct with commit message and author mapped to tagger"tag"(annotated): proceed with existingclient.Git.GetTag()call (no behavior change)pkg/github/repositories_test.gomockLightweightTagRefandmockCommitfixtures"successful lightweight tag retrieval"test casemockTagRefto includeType: github.Ptr("tag")for accuracyNotes
github.TagJSON structure for both tag types