Fail closed on unknown toolsets in strict mode#2118
Open
davidahmann wants to merge 1 commit intogithub:mainfrom
Open
Fail closed on unknown toolsets in strict mode#2118davidahmann wants to merge 1 commit intogithub:mainfrom
davidahmann wants to merge 1 commit intogithub:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Unknown toolset names are currently ignored with warnings, which can silently broaden/alter effective exposure when configs contain typos.
Why now
Strict environments need deterministic fail-closed startup on unknown toolset inputs.
What changed
--strict-toolsets(GITHUB_STRICT_TOOLSETS).pkg/github/server_test.gofor strict fail and non-strict allow paths.docs/toolsets-and-icons.mdwith strict-mode behavior and migration path.Validation
go test ./pkg/github -run "StrictToolsets|ResolveEnabledToolsets|NewMCPServer_CreatesSuccessfully"go test ./cmd/github-mcp-serverRefs #2117