Skip to content

C#: Add model validation for constructor summary models #21416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
owen-mc wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −1
Open

C#: Add model validation for constructor summary models #21416

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6996ea
Add model validation for constructor summary models
owen-mc Mar 5, 2026
3c36a9e
Correctly deal with generic types
owen-mc Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion csharp/ql/lib/semmle/code/csharp/dataflow/internal/ExternalFlow.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,12 +239,25 @@ module ModelValidation {
)
}

string getIncorrectConstructorSummaryOutput() {
exists(string namespace, string type, string name, string output |
type = name or
type = name + "<" + any(string s)
|
summaryModel(namespace, type, _, name, _, _, _, output, _, _, _) and
output.matches("ReturnValue%") and
result =
"Constructor model for " + namespace + "." + type +
" should use `Argument[this]` in the output, not `ReturnValue`."
)
}

/** Holds if some row in a MaD flow model appears to contain typos. */
query predicate invalidModelRow(string msg) {
msg =
[
getInvalidModelSignature(), getInvalidModelInput(), getInvalidModelOutput(),
KindVal::getInvalidModelKind()
getIncorrectConstructorSummaryOutput(), KindVal::getInvalidModelKind()
Comment on lines 255 to +260
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc comment for invalidModelRow says it detects rows that "appear to contain typos", but this predicate now also reports semantic validation issues (for example, incorrect constructor summary outputs and invalid kind values). Please update the comment to reflect the broader scope (e.g., invalid/suspicious model rows) so it stays accurate.

Copilot uses AI. Check for mistakes.
]
}
}
Expand Down