Java: validate constructor summary models#21415
Open
owen-mc wants to merge 3 commits intogithub:mainfrom
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
owen-mc
force-pushed
the
java/validate-constructor-summary-models
branch
from
a04cd48 to
579c871
Compare
michaelnebel
reviewed
Mar 5, 2026
Contributor
michaelnebel
left a comment
michaelnebel
left a comment
There was a problem hiding this comment.
Very nice!
Maybe add a QL Doc for the test.
If you intend to introduce the same test for C#, then be aware that the MaD contains type parameters as well.
| } | ||
|
|
||
| string getIncorrectConstructorSummaryOutput() { | ||
| exists(string namespace, string type, string name, string output | |
Contributor
There was a problem hiding this comment.
nit pick: Consider using package instead of namespace.
Contributor
Author
There was a problem hiding this comment.
I think it's better to move towards using the same variable names in all languages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The output column of a summary model for a constructor should use
Argument[this]instead ofReturnValue.