Skip to content

Update runner image versions to supported version#1066

Merged
knewbury01 merged 1 commit intogithub:mainfrom
knewbury01:knewbury01/fix-image-os
Mar 3, 2026
Merged

Update runner image versions to supported version#1066
knewbury01 merged 1 commit intogithub:mainfrom
knewbury01:knewbury01/fix-image-os

Conversation

@knewbury01
Copy link
Collaborator

@knewbury01 knewbury01 commented Mar 3, 2026

Description

Supported image os versions are listed here, the previous version used in some workflows - ubuntu 20 - was removed recently so the jobs requesting that label just hang forever.

Change request type

  • Release or process automation (GitHub workflows, internal scripts)
  • Internal documentation
  • External documentation
  • Query files (.ql, .qll, .qls or unit tests)
  • External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

  • No rules added
  • Queries have been added for the following rules:
    • rule number here
  • Queries have been modified for the following rules:
    • rule number here

Release change checklist

A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

  • The structure or layout of the release artifacts.
  • The evaluation performance (memory, execution time) of an existing query.
  • The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.

Author: Is a change note required?

  • Yes
  • No

🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.

  • Confirmed

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

  • Confirmed

Query development review checklist

For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:

Author

  • Have all the relevant rule package description files been checked in?
  • Have you verified that the metadata properties of each new query is set appropriately?
  • Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
  • Are the alert messages properly formatted and consistent with the style guide?
  • Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
    As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
  • Does the query have an appropriate level of in-query comments/documentation?
  • Have you considered/identified possible edge cases?
  • Does the query not reinvent features in the standard library?
  • Can the query be simplified further (not golfed!)

Reviewer

  • Have all the relevant rule package description files been checked in?
  • Have you verified that the metadata properties of each new query is set appropriately?
  • Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
  • Are the alert messages properly formatted and consistent with the style guide?
  • Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
    As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
  • Does the query have an appropriate level of in-query comments/documentation?
  • Have you considered/identified possible edge cases?
  • Does the query not reinvent features in the standard library?
  • Can the query be simplified further (not golfed!)

@knewbury01 knewbury01 self-assigned this Mar 3, 2026
Copilot AI review requested due to automatic review settings March 3, 2026 13:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates GitHub Actions workflow runner labels to avoid jobs hanging due to the removal of the previously referenced Ubuntu 20 runner image, keeping CI aligned with currently supported runner images.

Changes:

  • Update the OS label used in workflow-generated matrices from ubuntu-20.04-xl to ubuntu-24.04-xl in two workflows.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/verify-standard-library-dependencies.yml Updates the matrix OS label so dependency verification runs on a supported Ubuntu runner image.
.github/workflows/standard_library_upgrade_tests.yml Updates the matrix OS label so standard library upgrade tests run on a supported Ubuntu runner image.

Copy link
Contributor

@data-douser data-douser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The PR comments about ::set-output can be addressed in the future.

@knewbury01 knewbury01 enabled auto-merge March 3, 2026 14:06
Copy link
Collaborator

@mbaluda mbaluda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@knewbury01 knewbury01 added this pull request to the merge queue Mar 3, 2026
Merged via the queue into github:main with commit cced30c Mar 3, 2026
25 checks passed
@knewbury01 knewbury01 deleted the knewbury01/fix-image-os branch March 3, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants