Skip to content

Clean up pre GHES 3.14 code paths#3560

Merged
mbg merged 1 commit intomainfrom
henrymercer/ghes-3.13-cleanup
Mar 9, 2026
Merged

Clean up pre GHES 3.14 code paths#3560
mbg merged 1 commit intomainfrom
henrymercer/ghes-3.13-cleanup

Conversation

@henrymercer
Copy link
Contributor

A small cleanup, but I think still worth it.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Workflow types:

  • Advanced setup - Impacts users who have custom CodeQL workflows.
  • Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...).

Products:

  • Code Scanning - The changes impact analyses when analysis-kinds: code-scanning.
  • Code Quality - The changes impact analyses when analysis-kinds: code-quality.
  • Other first-party - The changes impact other first-party analyses.
  • Third-party analyses - The changes affect the upload-sarif action.

Environments:

  • GHES - Impacts CodeQL workflows on GitHub Enterprise Server.

How did/will you validate this change?

  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).
  • End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

  • Telemetry - I rely on existing telemetry or have made changes to the telemetry.
    • Alerts - New or existing monitors will trip if something goes wrong with this change.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner March 9, 2026 16:37
Copilot AI review requested due to automatic review settings March 9, 2026 16:37
@github-actions github-actions bot added the size/M Should be of average difficulty to review label Mar 9, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes code paths and tests specific to GHES versions earlier than 3.14, simplifying behavior around SARIF merge deprecation warnings and minor telemetry comment cleanup.

Changes:

  • Simplifies shouldShowCombineSarifFilesDeprecationWarning to no longer depend on the GitHub version (removes pre-3.14 GHES special-casing).
  • Updates unit tests to match the simplified warning behavior and removes GHES 3.13-specific test cases.
  • Removes an outdated comment about RUNNER_ARCH availability.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/upload-lib.ts Removes pre-GHES-3.14 branching for the SARIF merge deprecation warning and updates call sites.
src/upload-lib.test.ts Updates tests for the changed warning API and drops GHES 3.13-specific expectations.
src/status-report.ts Removes an outdated GHES-version-specific comment while retaining the env-var presence guard.
lib/upload-sarif-action.js Generated output reflecting src/ changes.
lib/upload-lib.js Generated output reflecting src/ changes.
lib/init-action-post.js Generated output reflecting src/ changes.
lib/analyze-action.js Generated output reflecting src/ changes.

@henrymercer henrymercer added this pull request to the merge queue Mar 9, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 9, 2026
@mbg mbg added this pull request to the merge queue Mar 9, 2026
Merged via the queue into main with commit 0ad7d7b Mar 9, 2026
248 checks passed
@mbg mbg deleted the henrymercer/ghes-3.13-cleanup branch March 9, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Should be of average difficulty to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants