Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes code paths and tests specific to GHES versions earlier than 3.14, simplifying behavior around SARIF merge deprecation warnings and minor telemetry comment cleanup.
Changes:
- Simplifies
shouldShowCombineSarifFilesDeprecationWarningto no longer depend on the GitHub version (removes pre-3.14 GHES special-casing). - Updates unit tests to match the simplified warning behavior and removes GHES 3.13-specific test cases.
- Removes an outdated comment about
RUNNER_ARCHavailability.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/upload-lib.ts | Removes pre-GHES-3.14 branching for the SARIF merge deprecation warning and updates call sites. |
| src/upload-lib.test.ts | Updates tests for the changed warning API and drops GHES 3.13-specific expectations. |
| src/status-report.ts | Removes an outdated GHES-version-specific comment while retaining the env-var presence guard. |
| lib/upload-sarif-action.js | Generated output reflecting src/ changes. |
| lib/upload-lib.js | Generated output reflecting src/ changes. |
| lib/init-action-post.js | Generated output reflecting src/ changes. |
| lib/analyze-action.js | Generated output reflecting src/ changes. |
mbg
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small cleanup, but I think still worth it.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
dynamicworkflows (Default Setup, Code Quality, ...).Products:
analysis-kinds: code-scanning.analysis-kinds: code-quality.upload-sarifaction.Environments:
How did/will you validate this change?
.test.tsfiles).pr-checks).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist