Load custom repository properties on GHES and remove feature flag#3559
Merged
henrymercer merged 5 commits intomainfrom Mar 9, 2026
Merged
Load custom repository properties on GHES and remove feature flag#3559henrymercer merged 5 commits intomainfrom
henrymercer merged 5 commits intomainfrom
Conversation
All supported versions of GHES support the repository properties API.
mbg
previously approved these changes
Mar 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the now-unneeded repository properties feature flag and enables loading custom repository properties on GHES, so server-side configuration (e.g. github-codeql-disable-overlay) works consistently across GitHub.com and GHES.
Changes:
- Remove the
UseRepositoryPropertiesfeature flag and its gating logic. - Enable repository properties loading on GHES by removing the GHES short-circuit.
- Update unit tests and changelog entry accordingly (and regenerate
lib/outputs).
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/init-action.ts | Removes feature-flag gating for repository properties loading. |
| src/feature-flags/properties.ts | Removes the GHES “always return {}” behavior so the API is called on GHES too. |
| src/feature-flags/properties.test.ts | Updates tests to match the new loadPropertiesFromApi signature and behavior. |
| src/feature-flags.ts | Removes the UseRepositoryProperties feature flag from the enum and config. |
| CHANGELOG.md | Adds an UNRELEASED entry describing repository properties now loading on GHES. |
| lib/upload-sarif-action.js | Generated output updated for removed feature flag. |
| lib/upload-sarif-action-post.js | Generated output updated for removed feature flag. |
| lib/upload-lib.js | Generated output updated for removed feature flag. |
| lib/start-proxy-action.js | Generated output updated for removed feature flag. |
| lib/start-proxy-action-post.js | Generated output updated for removed feature flag. |
| lib/setup-codeql-action.js | Generated output updated for removed feature flag. |
| lib/resolve-environment-action.js | Generated output updated for removed feature flag. |
| lib/init-action.js | Generated output updated for removed feature flag and repo properties changes. |
| lib/init-action-post.js | Generated output updated for removed feature flag. |
| lib/autobuild-action.js | Generated output updated for removed feature flag. |
| lib/analyze-action.js | Generated output updated for removed feature flag. |
| lib/analyze-action-post.js | Generated output updated for removed feature flag. |
mbg
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
dynamicworkflows (Default Setup, Code Quality, ...).Products:
analysis-kinds: code-scanning.analysis-kinds: code-quality.upload-sarifaction.Environments:
github.comand/or GitHub Enterprise Cloud with Data Residency.How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist