Skip to content

feat(ci): add mago to CI pipeline#2020

Open
Litarnus wants to merge 2 commits intomasterfrom
mago-ci
Open

feat(ci): add mago to CI pipeline#2020
Litarnus wants to merge 2 commits intomasterfrom
mago-ci

Conversation

@Litarnus
Copy link
Contributor

@Litarnus Litarnus commented Mar 4, 2026

Introducing Mago to the PHP SDK. For the initial version, I added all current failures to the baseline file to keep the PR small regarding code changes.

closes PHP-69

@Litarnus Litarnus marked this pull request as ready for review March 4, 2026 15:29
@linear
Copy link

linear bot commented Mar 4, 2026

@stayallive
Copy link
Collaborator

Worth seeing this as an opportunity to remove psalm (#1898) to prevent running three tools and see how it works before we commit? Ideally we have a single tool instead of many to prevent them disagreeing with each other.

@Litarnus
Copy link
Contributor Author

Litarnus commented Mar 9, 2026

Worth seeing this as an opportunity to remove psalm (#1898) to prevent running three tools and see how it works before we commit?

Good point, I make sure to remove psalm before this gets merged. I think we have to have Mago running for some time in the repo to see how well it works.

Ideally we have a single tool instead of many to prevent them disagreeing with each other.

Yes, that is my goal as well. So far it seems quite powerful and I'm fairly optimistic it can replace all other tools (including PHP-CS-FIXER)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants