Skip to content

fix(screenshot): Add dontwarn replay rules to sentry-android-core#5153

Open
romtsn wants to merge 3 commits intomainfrom
rz/fix/screenshot-masking-rules
Open

fix(screenshot): Add dontwarn replay rules to sentry-android-core#5153
romtsn wants to merge 3 commits intomainfrom
rz/fix/screenshot-masking-rules

Conversation

@romtsn
Copy link
Member

@romtsn romtsn commented Mar 4, 2026

📜 Description

Claude fumbled and put the rules to the test project as opposed to having it in sentry-android-core so it does not warn customers' builds

💡 Motivation and Context

Closes #5152

💚 How did you test it?

CI should cover (AGP test matrix)

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Bug Fixes 🐛

  • (screenshot) Add dontwarn replay rules to sentry-android-core by romtsn in #5153

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 319.96 ms 367.30 ms 47.34 ms
Size 1.58 MiB 2.29 MiB 722.97 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
91bb874 314.47 ms 440.00 ms 125.53 ms
dba088c 333.98 ms 381.16 ms 47.18 ms
d15471f 310.66 ms 368.19 ms 57.53 ms
bbc35bb 298.53 ms 372.17 ms 73.64 ms
d15471f 307.28 ms 381.85 ms 74.57 ms
ad8da22 362.98 ms 453.94 ms 90.96 ms
cf708bd 408.35 ms 458.98 ms 50.63 ms
96449e8 361.30 ms 423.39 ms 62.09 ms
27d7cf8 309.43 ms 364.27 ms 54.85 ms
91bb874 311.00 ms 363.47 ms 52.47 ms

App size

Revision Plain With Sentry Diff
91bb874 1.58 MiB 2.13 MiB 559.07 KiB
dba088c 1.58 MiB 2.13 MiB 558.99 KiB
d15471f 1.58 MiB 2.13 MiB 559.54 KiB
bbc35bb 1.58 MiB 2.12 MiB 553.01 KiB
d15471f 1.58 MiB 2.13 MiB 559.54 KiB
ad8da22 1.58 MiB 2.29 MiB 719.83 KiB
cf708bd 1.58 MiB 2.11 MiB 539.71 KiB
96449e8 1.58 MiB 2.11 MiB 539.35 KiB
27d7cf8 1.58 MiB 2.12 MiB 549.42 KiB
91bb874 1.58 MiB 2.13 MiB 559.07 KiB

Previous results on branch: rz/fix/screenshot-masking-rules

Startup times

Revision Plain With Sentry Diff
702cc3e 327.94 ms 376.94 ms 49.00 ms

App size

Revision Plain With Sentry Diff
702cc3e 1.58 MiB 2.29 MiB 722.97 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

R8 task fails because of replay proguard rules

1 participant