Fix Coverage Display in Binary Ninja 5.X#163
Open
Exiled1 wants to merge 6 commits intogaasedelen:developfrom
Open
Fix Coverage Display in Binary Ninja 5.X#163Exiled1 wants to merge 6 commits intogaasedelen:developfrom
Exiled1 wants to merge 6 commits intogaasedelen:developfrom
Conversation
…because dockable widgets no longer are supported, need to migrate everything to a SidebarWidget
…across CoverageOverview and lighthousewidget.visible not existing, still need large changes to migrate out of dockablewidgets.
This was referenced Nov 28, 2025
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took a crack at getting Lighthouse to work in the newest stable release of binary ninja. I worked on top of the fix made by #148, however I noticed that the code didn't properly display a coverage file, so I went through and updated the binja API. Although I might have messed up the Ida display by messing with the core api. Migrated from DockableWidget to a more supported SidebarWidget, which also helps with some of the annoying issues. I did still have to do some hacky life cycle management.