Verify mkcert binary SHA-256 checksum before execution#588
Draft
Copilot wants to merge 3 commits intohuntercaron/mkcert-secure-wsfrom
Draft
Verify mkcert binary SHA-256 checksum before execution#588Copilot wants to merge 3 commits intohuntercaron/mkcert-secure-wsfrom
Copilot wants to merge 3 commits intohuntercaron/mkcert-secure-wsfrom
Conversation
2 tasks
Co-authored-by: Nick-Lucas <8896153+Nick-Lucas@users.noreply.github.com>
Co-authored-by: Nick-Lucas <8896153+Nick-Lucas@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] WIP Address security implications and best practices for secure websockets
Verify mkcert binary SHA-256 checksum before execution
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the security implications of downloading and executing the mkcert binary without integrity verification. Since mkcert installs a root CA into the system trust store, a tampered binary (MITM or compromised release) could install a malicious CA and enable HTTPS interception.
Changes
darwin-amd64/arm64,linux-amd64/arm/arm64,windows-amd64/arm64) — must be updated alongsideMKCERT_VERSIONgetDownloadUrl→getDownloadInfo— now returns{ url, expectedChecksum }so the checksum travels with the URL~/.framer/code-link/rootCA-key.pemmust not be shared/committed) and the checksum update requirementChangelog
Testing
~/.framer/code-link/mkcert(or the.exe), run the CLI, confirm the binary is downloaded and the WSS server startsecho x >> ~/.framer/code-link/mkcert), confirm a re-download is triggered with the checksum warning🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.