fix: return 400/501 instead of 500 for invalid country codes#84
Open
aditya047-stack wants to merge 2 commits intofoss42:mainfrom
Open
fix: return 400/501 instead of 500 for invalid country codes#84aditya047-stack wants to merge 2 commits intofoss42:mainfrom
aditya047-stack wants to merge 2 commits intofoss42:mainfrom
Conversation
- Add not_implemented_501() helper in models/responses.py- Fix /subdivisions to return 501 for unsupported countries- Fix /data, /flag, /name, /officialname to return 400 for invalid codes- Separate ValueError and NotImplementedError handling
Member
|
It should be data not found error instead of server side error. |
Author
|
Thanks for addressing this issue and helping to solve it .i have updated the fix based on feedback — changed 400 to 404 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83
Changes
##Before

##After
