Fix build report timing issue

[a-maurice]

Description

Provide details of the change, and generalize the change in the PR title above.

The build report was failing to find Source Tests on somedays because to find them it was looking if the timestamp began with "09:0", but sometimes the tests take a bit longer to start running. Change it to accept runs that started within 20 minutes instead.

---

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Running locally.

---

Type of Change

Place an x the applicable box:

• Bug fix. Add the issue # below if applicable.
• New feature. A non-breaking change which adds functionality.
• Other, such as a build process or documentation change.

---

Notes

• Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
• Read the contribution guidelines CONTRIBUTING.md.
• Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the reliability of the build report by addressing a timing sensitivity issue. The previous implementation sometimes failed to correctly identify source tests if their start times deviated slightly from a hardcoded timestamp. The changes introduce a more robust time comparison mechanism, allowing for a reasonable delay in test execution, thereby ensuring more consistent and accurate reporting.

Highlights

• Enhanced Test Time Matching: The build report's logic for identifying source tests was made more flexible. Previously, it relied on a strict string match for test start times (e.g., "09:0"). This has been updated to allow for a 20-minute window after the expected start hour, preventing failures when tests start slightly later than anticipated.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• scripts/gha/report_build_status.py
  • Replaced general_test_time and firestore_test_time string variables with integer general_test_hour, firestore_test_hour, and test_time_minute_range variables.
  • Modified the conditional logic for identifying source tests to compare the run's hour and minute against the new hour and minute range variables, instead of checking for a substring in the run's date string.

Activity

• No activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively addresses the build report timing issue by refactoring the time comparison logic. The change from string-based time matching to a more precise hour and minute range comparison using integer variables significantly improves the robustness and flexibility of the test time detection. The new variables are clearly named, and the added comments provide valuable context for the minute range, enhancing code clarity. Overall, this is a well-implemented and beneficial change.