feat(fcm): Add support for restricted satellite API#1191
feat(fcm): Add support for restricted satellite API#1191jonathanedey wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new configuration option for Android push notifications in Firebase Cloud Messaging, enabling developers to explicitly allow message delivery even when a device is connected via a restricted satellite network. It also includes a minor update to the description of an existing network-related setting for better understanding. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds support for the restricted_satellite_ok option for Android push notifications. The changes include adding the new field to AndroidConfig and its builder, along with a new test case to verify the functionality. The implementation is straightforward and follows existing patterns. I've identified an opportunity to improve test code maintainability by refactoring duplicated test logic.
This change introduces the
restrictedSatelliteOkconfiguration option for Android push notifications, providing developers with the ability to opt-in to delivering messages even when a user's device is connected via a restricted satellite network. This PR also follows up #1145 , to update the description forbandwidthConstrainedOk.