Remove legacy error downcasting from miner actor#1322
Draft
Conversation
Stebalien
approved these changes
Jun 29, 2023
Member
Stebalien
left a comment
Stebalien
left a comment
There was a problem hiding this comment.
I'm generally in favor of this. We'll lose a little bit of information as implemented, but that likely doesn't matter.
| quant, | ||
| ) | ||
| .map_err(|e| { | ||
| e.downcast_default( |
Member
There was a problem hiding this comment.
Note: this means:
- If anything inside here specified an actor error, we'll lose it.
- We won't keep, e.g., serialization errors.
However... honestly, I think that's fine. I'd actually like to move away from "serialization" errors and stick to "illegal state" and "illegal argument" errors.
Member
Author
|
@Stebalien thanks for reviewing this. I may have been a bit premature. There are some other cases of lost information, but I was trying not to do that. I will write up an issue with more detail on the challenges. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces a swathe of verbose and opaque error conversion with ActorErrors. The general pattern is to always return an
ActorErrorfrom the state objects, needing minimal context or conversion in the actor code. This is almost all mechanical.This hasn't purged
anyhowentirely from the miner actor, it's still used in some utility modules.There'll be more of these (smaller) to come. @Stebalien if you review this one, I'll send future iterations on the same pattern only to @alexytsu
See #52.