Fix Slack auth filter not halting on invalid signature#67
Closed
Fix Slack auth filter not halting on invalid signature#67
Conversation
`valid_slack_request?` returned a boolean but never called `head` or `render`, so unauthenticated Slack requests were silently allowed through. Added `head :unauthorized and return` to halt the filter chain, consistent with the fix applied in #66.
b84c0cf to
b535ade
Compare
JuanVqz
added a commit
that referenced
this pull request
Mar 6, 2026
Replaces #66, #67, #68, #70 with a single cohesive fix: - Merge check_session_expiry + check_user_token into one authenticate! callback, eliminating the double-render risk by design - SessionsController and Slack::ApplicationController now each skip a single authenticate! instead of managing multiple callbacks - Rename valid_slack_request? to verify_slack_request! and make it halt with head :unauthorized when signature verification fails - Replace head :unprocessable_entity in send_message with logging and Sentry.capture_exception so notification failures never affect the HTTP response back to Slack
Member
Author
|
Superseded by #71 which addresses this and three other related bugs with a more robust design. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
valid_slack_request?inSlack::ApplicationControllerreturned a boolean but never calledrenderorhead, so the before_action never halted the filter chain. Every Slack endpoint accepted any request regardless of signature validity.Fix
Added
head :unauthorized and returnto halt the chain when verification fails, consistent with the pattern used in #66:Tests
Added
Slack::PuzzlesControllerTestcovering: