Add ReactFeatureFlags support to eprh#35951
Open
jackpope wants to merge 1 commit intofacebook:mainfrom
Open
Conversation
jackpope
commented
Mar 3, 2026
scripts/rollup/build.js
Outdated
Comment on lines
+385
to
+398
| : false, | ||
| { | ||
| name: 'rollup-plugin-flow-remove-types', | ||
| transform(code, id) { | ||
| if (bundle.tsconfig != null && !id.endsWith('.js')) { | ||
| return null; | ||
| } | ||
| const transformed = flowRemoveTypes(code); | ||
| return { | ||
| code: transformed.toString(), | ||
| map: null, | ||
| }; | ||
| }, | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
Updates the build for eslint-plugin-react-hooks to run flowRemoveTypes on all .js files. Needed to support the import of feature flags.
jackpope
force-pushed
the
compiler-feature-flags
branch
from
ff343c6 to
e4a4adb
Compare
jackpope
force-pushed
the
compiler-feature-flags
branch
from
e4a4adb to
3a98f69
Compare
|
Comparing: 4cc5b7a...3a98f69 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're currently hardcoding experimental options to
eslint-plugin-react-hooks. This blocks the release on features that might not be ready.This PR extends the ReactFeatureFlag infra to support flags for
eslint-plugin-react-hooks. An alternative would be to create a separate flag system for build tools, but for now we have a small number of these and reusing existing infra seems like the simplest approach.I ran a full
yarn buildand checked the output resolved the flag values as expected:build/oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js
build/facebook-www/ESLintPluginReactHooks-dev.classic.js